Skip to content

chore: better masking #19423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexghr merged 1 commit into from
Jan 13, 2026
Merged

chore: better masking #19423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions spartan/scripts/setup_gcp_secrets.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ mask_secret_value() {
local secret_value
secret_value=$(cat "$secret_file")

# Always mask the full value first as a safety net
echo "::add-mask::$secret_value"

# Check if this environment variable contains JSON that should be individually masked
local is_json_secret=false
for json_var in "${JSON_SECRETS[@]}"; do
Expand All @@ -67,6 +64,8 @@ mask_secret_value() {
jq -r '.[]' "$secret_file" | while IFS= read -r element; do
echo "::add-mask::$element"
done
else
echo "::add-mask::$secret_value"
fi
}

Expand Down
Loading