Merged
Conversation
`round.cpp` and `round.hpp` contained a `round_to_nearest_byte(num_bits)` function that rounds up `num_bits` to the nearest byte. When constructing the vector of inputs in a Blake2s/Blake3 constraint, `num_bits` is set to 8 (see [this](https://github.com/AztecProtocol/aztec-packages/blob/4fc30d81acf2c727e6becd7376de93185e22dd92/barretenberg/cpp/src/barretenberg/dsl/acir_format/acir_to_constraint_buf.cpp#L666-L667)). Hence, `round_to_nearest_byte` is no longer needed and the number of bytes can simply be set to 1. This PR removes `round.cpp` and `round.hpp`. The relevant constraint files that were dependent are also updated accordingly.
federicobarbacovi
approved these changes
Jan 8, 2026
### 🧾 Audit Context Documents translator VM. ### 🛠️ Changes Made - Adds README with translator architecture and relations ### ✅ Checklist - [x] Audited all methods of the relevant module/class - [ ] Audited the interface of the module/class with other (relevant) components - [ ] Documented existing functionality and any changes made (as per Doxygen requirements) - [ ] Resolved and/or closed all issues/TODOs pertaining to the audited files - [ ] Confirmed and documented any security or other issues found (if applicable) - [ ] Verified that tests cover all critical paths (and added tests if necessary) - [ ] Updated audit tracking for the files audited (check the start of each file you audited) ### 📌 Notes for Reviewers No logic changes --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
TomAFrench
requested changes
Jan 8, 2026
Member
TomAFrench
left a comment
TomAFrench
left a comment
There was a problem hiding this comment.
This is reverting a noir sync.
Contributor
@TomAFrench my bad. Is this the right noir version now? |
TomAFrench
approved these changes
Jan 8, 2026
## Summary - Adds a more helpful error message when `bb verify` fails because the vk file doesn't exist - Previously users got a confusing "Unable to open file: ./target/vk" error - Now the error provides actionable guidance on how to generate or specify the vk file ## Test plan - Added `VerifyWithMissingVkGivesActionableError` test that verifies the error message contains: - `--write_vk` flag guidance - `bb write_vk` command guidance - `--vk_path` option guidance Fixes #17726
### 🧾 Audit Context Audit of the `utils.hpp` and `utils.cpp` files inside `dsl`. ### 🛠️ Changes Made - Updated some comments - Throw if type is not recognised in `add_to_witness_vector_and_track_indices` - Add commit hashes and update audit scopes ### ✅ Checklist - [ ] Audited all methods of the relevant module/class - [ ] Audited the interface of the module/class with other (relevant) components - [ ] Documented existing functionality and any changes made (as per Doxygen requirements) - [ ] Resolved and/or closed all issues/TODOs pertaining to the audited files - [ ] Confirmed and documented any security or other issues found (if applicable) - [ ] Verified that tests cover all critical paths (and added tests if necessary) - [ ] Updated audit tracking for the files audited (check the start of each file you audited) ### 📌 Notes for Reviewers (Optional) Call out anything that reviewers should pay close attention to — like logic changes, performance implications, or potential regressions.
Mostly adding lots of documentation (inline, block and README) - no logic changes. Also adds a handful of AUDITTODOs to be resolved in the next PR. Note: VK changes are trivial and due only to the removal of some unused entries from the `BasicTableId` enum.
Improve the info message displayed when no contract artifacts are found when calling `aztec compile`.
Separated convoluted Transcript subclasses from `UltraFlavor` and other Flavors derived from it. Those are only used in a specific type of failure testing where some proof elements are tampered with. The serde logic now lives in the `StructuredProof` class that supports **all** Ultra and Mega derivatives. Simplification of the Flavors' Transcripts made `VerificationKey` subclasses less convoluted, and as a result I was able to re-use base Native and Stdlib VerificationKey classes for all Ultra-Mega Flavors. Closes AztecProtocol/barretenberg#1355
iakovenkos
requested review from
IlyasRidhuan,
fcarreiro and
jeanmon
as code owners
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore: remove round.cpp and round.hpp in dsl/acir_format (#19412)
chore: docs for translator (#19056)
chore: update noir/noir-repo to match next branch
chore: update avm-transpiler Cargo.lock for noir submodule
fix: revert noir/noir-repo to match next and update Cargo.lock
fix: add actionable error when bb verify cannot find vk file (#19398)
chore:
utils.cppaudit (#19425)chore: sha audit 1 (#19072)
fix: improve no artifacts found message to include search path (#19432)
chore: simplify Flavors' Transcripts + VKs deduplication (#19326)
Add correct VKSerializationMode to AVM VerificationKey Classes
END_COMMIT_OVERRIDE