feat: store event randomness in database #19369
Merged
+63
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AztecBot
force-pushed
the
nv/improve-evt-encoding
branch
2 times, most recently
from
9154f9e to
72c0a1a
Compare
Contributor
|
Will review once rebased. |
Merge after #19366. With this we'll be storing the randomness contained in the event, which while currently unused would be required to recompute the commitment and validate that the event exists externally. I didn't add it to the API yet, so the queries don't return it, because the store is in such a poor state that it's better to re-do it entirely. Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com> Co-authored-by: benesjan <janbenes1234@gmail.com>
AztecBot
force-pushed
the
nico/f-204-store-event-randomness-in-database
branch
from
b98c7aa to
68f676a
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #19366.
With this we'll be storing the randomness contained in the event, which while currently unused would be required to recompute the commitment and validate that the event exists externally. I didn't add it to the API yet, so the queries don't return it, because the store is in such a poor state that it's better to re-do it entirely.