feat: testConnection for filestores #19268
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrzeszutko
force-pushed
the
feature/blob-filestore-test-connection
branch
from
0769274 to
9f997dc
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
PhilWindle
reviewed
Jan 2, 2026
| } | ||
|
|
||
| /** Stops the publisher, cleaning up any periodic tasks. */ | ||
| public async stop(): Promise<void> { |
Collaborator
There was a problem hiding this comment.
I feel like this isn't the correct place to do this. Presumably the blob client is created once and given to all created instances of SequencerPublisher. Who ultimately owns the blob client? Is it the node? It should probably be cleaned up by it's owner.
Collaborator
|
Generally seems fine however, I think there is an issues with ownership/cleanup of the blob client. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented testConnection for filestores.
All file stores (S3, GCS, HTTP, local) test connectivity by checking if a well-known healthcheck file (
.healthcheck) exists. This approach was chosen because:When uploading is enabled, the sequencer uploads the healthcheck file on startup and then periodically re-uploads it (by default every 60 minutes) to ensure it remains available. This guards against accidental deletion, storage pruning, or other failures that might remove the file.