Skip to content

fix!: missing bool selectors in ecc_mem, to_radix_mem, bitwise, poseidon2_mem PILs #19256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dbanks12 merged 1 commit into from
Jan 6, 2026
Merged

fix!: missing bool selectors in ecc_mem, to_radix_mem, bitwise, poseidon2_mem PILs #19256

dbanks12 merged 1 commit into from
Jan 6, 2026

Conversation

@dbanks12
Copy link
Contributor

@dbanks12 dbanks12 commented Dec 24, 2025 •
edited
Loading

Found via claude-audits

@dbanks12 dbanks12 marked this pull request as ready for review December 24, 2025 22:48
@dbanks12 Graphite App
Copy link
Contributor Author

dbanks12 commented Dec 24, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

jeanmon
jeanmon approved these changes Jan 5, 2026
View reviewed changes
Copy link
Contributor

@jeanmon jeanmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches

@dbanks12 dbanks12 force-pushed the db/missing-bool-sels branch from fbcc6a1 to 8dc250f Compare January 6, 2026 19:34
@dbanks12 dbanks12 changed the title fix!: missing bool selectors in ecc_mem and to_radix_mem pils fix!(avm): missing bool selectors in ecc_mem, to_radix_mem, bitwise, poseidon2_mem PILs Jan 6, 2026
@dbanks12 dbanks12 changed the title fix!(avm): missing bool selectors in ecc_mem, to_radix_mem, bitwise, poseidon2_mem PILs fix(avm)!: missing bool selectors in ecc_mem, to_radix_mem, bitwise, poseidon2_mem PILs Jan 6, 2026
@dbanks12 dbanks12 mentioned this pull request Jan 6, 2026
Closed
@dbanks12 dbanks12 changed the title fix(avm)!: missing bool selectors in ecc_mem, to_radix_mem, bitwise, poseidon2_mem PILs fix!: missing bool selectors in ecc_mem, to_radix_mem, bitwise, poseidon2_mem PILs Jan 6, 2026
@dbanks12 dbanks12 mentioned this pull request Jan 6, 2026
Closed
@dbanks12 dbanks12 force-pushed the db/missing-bool-sels branch from 8dc250f to 3d23d0c Compare January 6, 2026 19:57
@dbanks12 dbanks12 force-pushed the db/missing-bool-sels branch from 3d23d0c to 542be45 Compare January 6, 2026 20:09
@dbanks12 dbanks12 mentioned this pull request Jan 6, 2026
Merged
@AztecBot
Copy link
Collaborator

AztecBot commented Jan 6, 2026

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (\0338;;http://ci.aztec-labs.com/233606a497042f9d�233606a497042f9d8;;�\033):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_p2p/multiple_validators_sentinel.parallel.test.ts "collects attestations for validators in proposer node when block is not published" (102s) (code: 1) group:e2e-p2p-epoch-flakes (\033dbanks12\033: fix!: missing bool selectors in ecc_mem and to_radix_mem pils)

@dbanks12 dbanks12 merged commit 2842a5d into merge-train/avm Jan 6, 2026
10 of 11 checks passed
@dbanks12 dbanks12 deleted the db/missing-bool-sels branch January 6, 2026 20:39
@AztecBot AztecBot mentioned this pull request Jan 6, 2026
Merged
@dbanks12 dbanks12 mentioned this pull request Jan 6, 2026
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 7, 2026
@AztecBot
feat: merge-train/avm (#19363)
26f20c6 
BEGIN_COMMIT_OVERRIDE
chore: claude-generated pre-audit of ecc.pil in avm - added edge-case
tests (#19246)
fix!: missing bool selectors in ecc_mem, to_radix_mem, bitwise,
poseidon2_mem PILs (#19256)
END_COMMIT_OVERRIDE
@dbanks12 dbanks12 mentioned this pull request Jan 7, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeanmon jeanmon jeanmon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dbanks12 @AztecBot @jeanmon