Merged
Conversation
Introduces a CI workflow for testing and linting across multiple OS and Python versions, and a publish workflow for building and releasing the package to PyPI on tagged releases. Ensures version consistency between pyproject.toml and git tags before publishing.
Replaced Black with Ruff in pre-commit and pyproject.toml, adding Ruff configuration and dev dependency. Updated test files to use triple double quotes for SQL strings, renamed duplicate test functions, and made minor formatting improvements. Updated timing output formatting and adjusted speed test timings.
Changed SQL query string delimiters from single to double quotes in test files for consistency. Updated pre-commit-hooks version from v3.3.0 to v5.0.0 in .pre-commit-config.yaml.
Improved regex in read_python_file to correctly detect SQL strings in both triple single and double quotes, and fixed index drift when replacing content. Updated README with clearer installation, usage, and development instructions. Excluded test fixtures from ruff formatting in pyproject.toml. Expanded and corrected test fixtures to cover more SQL string cases.
Relocated the exclusion of test fixture files from the general ruff config to the [tool.ruff.format] section to ensure only formatting is skipped for these files, preserving their structure.
Adds --show-diff-on-failure to pre-commit in CI for better debugging. Updates AGENTS.md with workflow locations. Fixes whitespace in SQL examples in test files. Minor formatting improvement in regex construction in readsql/__main__.py.
Removed the zimports pre-commit hook and enabled Ruff's import sorting (I) in pyproject.toml. Also reordered imports in tests/timing.py to comply with the new linting rules.
Documented the replacement of zimports with ruff for import sorting and the addition of GitHub Actions workflows for CI and publishing to PyPI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a CI workflow for testing and linting across multiple OS and Python versions, and a publish workflow for building and releasing the package to PyPI on tagged releases. Ensures version consistency between pyproject.toml and git tags before publishing.