Skip to content

Updates ONVIF Media Signing to r25.12.1 #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bjornvolcker merged 2 commits into from
Jan 7, 2026
Merged

Updates ONVIF Media Signing to r25.12.1 #515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
851a72c
Updates ONVIF Media Signing to r25.12.0
bjornvolcker Dec 30, 2025
33176e4
Updates to r25.12.1
bjornvolcker Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/src/sv_authenticity.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,9 +464,8 @@ transfer_onvif_latest(signed_video_latest_validation_t *latest,
break;
}
latest->has_timestamp = true;
latest->start_timestamp = convert_1601_to_unix_us(onvif_latest->timestamp);
// ONVIF Media Signing currently only has one timestamp.
latest->end_timestamp = latest->start_timestamp;
latest->start_timestamp = convert_1601_to_unix_us(onvif_latest->start_timestamp);
latest->end_timestamp = convert_1601_to_unix_us(onvif_latest->end_timestamp);
}

static void
Expand Down
2 changes: 1 addition & 1 deletion lib/src/sv_internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
#define DEFAULT_HASH_SIZE (256 / 8)

#define SV_VERSION_BYTES 3
#define SIGNED_VIDEO_VERSION "v2.3.1"
#define SIGNED_VIDEO_VERSION "v2.3.2"
#define SV_VERSION_MAX_STRLEN 19 // Longest possible string including 'ONVIF' prefix

#define DEFAULT_AUTHENTICITY_LEVEL SV_AUTHENTICITY_LEVEL_FRAME
Expand Down
3 changes: 2 additions & 1 deletion lib/src/sv_onvif.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ typedef struct {
int number_of_pending_hashable_nalus;
char *validation_str;
char *nalu_str;
int64_t timestamp;
int64_t start_timestamp;
int64_t end_timestamp;
} onvif_media_signing_latest_validation_t;
// Defines onvif_media_signing_accumulated_validation_t
typedef struct {
Expand Down
2 changes: 1 addition & 1 deletion media-signing-framework
Open in desktop
Submodule media-signing-framework updated 14 files
+19 −14 examples/apps/validator/main.c
+22 −2 lib/src/includes/onvif_media_signing_validator.h
+19 −5 lib/src/oms_authenticity_report.c
+18 −4 lib/src/oms_common.c
+1 −1 lib/src/oms_defines.h
+25 −2 lib/src/oms_nalu_list.c
+12 −1 lib/src/oms_nalu_list.h
+7 −4 lib/src/oms_signer.c
+39 −17 lib/src/oms_tlv.c
+4 −0 lib/src/oms_validator.c
+1 −1 meson.build
+7 −4 tests/check/check_onvif_media_signing_common.c
+15 −0 tests/check/check_onvif_media_signing_signer.c
+107 −52 tests/check/check_onvif_media_signing_validator.c
2 changes: 1 addition & 1 deletion meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
project('signed-video-framework', 'c',
version : '2.3.1',
version : '2.3.2',
meson_version : '>= 0.53.0',
default_options : [ 'warning_level=2',
'werror=true',
Expand Down
4 changes: 2 additions & 2 deletions tests/check/test_helpers.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,8 +680,8 @@ validate_stream(signed_video_t *sv,
public_key_has_changed |= latest->public_key_has_changed;

if (latest->has_timestamp) {
if (sv->onvif || sv->legacy_sv) {
// Media Signing and Legacy code only have one timestamp
if (sv->legacy_sv) {
// Legacy code only have one timestamp
ck_assert_int_eq(latest->start_timestamp, latest->end_timestamp);
} else {
if (has_timestamp) {
Expand Down
Loading