Add tap gesture to provide additional feature info#86
Open
mfcollins3 wants to merge 1 commit intoAvdLee:mainfrom
Open
Add tap gesture to provide additional feature info#86mfcollins3 wants to merge 1 commit intoAvdLee:mainfrom
mfcollins3 wants to merge 1 commit intoAvdLee:mainfrom
Conversation
I enhanced RoadmapFeature by adding a URL property that can be used to display additional information about the feature request, such as a GitHub issue or a blog post. I enhanced RoadmapView by adding a bindable variable for the selected feature in the list. I added a tap gesture recognizer that will update the bindable value with the selected feature. This will allow a developer to navigate to another view to show more detailed information about the feature, or to use the new url field to open a web view to show the detailed information about the feature.
mfcollins3
requested review from
AvdLee,
hiddevdploeg and
jordibruin
as code owners
Owner
|
@mfcollins3 I know it's been a while, but would you be open to solve the merge conflicts so we can merge this in? 🙏 |
Author
|
Forgot about this. I will work on this today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I enhanced
RoadmapFeatureby adding aurlproperty that can be used to display additional information about the feature request, such as a GitHub issue or a blog post.I enhanced
RoadmapViewby adding a bindable variable for the selected feature in the list. I added a tap gesture recognizer that will update the bindable value with the selected feature. This will allow a developer to navigate to another view to show more detailed information about the feature, or to use the newurlfield to open a web view to show the detailed information about the feature.I had to extend
RoadmapFeatureto implementEquatable. If a developer uses the new bindable field onRoadmapViewand uses theonChange(of:)view modifier to react to a feature being selected, the type is required to conform toEquatable.