Repository navigation
Make cloud sync opt-in and gate collection on onboarding - #85
Merged
Merged
Conversation
The status line and the uploaders used different rules for "is sync on". whoami/sync status/doctor required prompt_storage != local AND an HTTP notes backend, while metrics, commit summaries and transcript uploaders only checked prompt_storage != local. A fresh install that ran `autter login` without connected onboarding showed "Cloud upload: off" while uploading. - One predicate for sync: Config::platform_sync_enabled() and platform_sync_enabled_now() share sync_mode_permits_upload (not local AND HTTP notes backend). The status line calls the same function. - Login no longer turns on sync: onboarding asks the mode even when already signed in, and login stops promising/restarting for uploads when not connected. - No collection before onboarding: the transcript worker (and its sweep of agent history) starts only after onboarding or explicit connected mode; plain commands and doctor no longer start the background service before setup; anonymous telemetry is off until telemetry_oss is "on". - Docs and test fixtures updated (shared connected_mode test helper). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
whoami/sync status/doctortreated sync as on only withprompt_storage != localand an HTTP notes backend. The metrics, commit-summary and transcript uploaders only checkedprompt_storage != local. On a fresh install, runningautter loginwithout connected onboarding left the notes backend on git notes, so the status line said off while the daemon uploaded metrics, commit summaries and transcripts.~/.claude/projectshistory on startup, and telemetry was on unlesstelemetry_osswas set to"off".Changes
Config::platform_sync_enabled()andplatform_sync_enabled_now()now sharesync_mode_permits_upload: sync is on only when storage is not local and the notes backend is HTTP (or both). The status line uses the same function, so "off" means nothing is sent.autter loginno longer says "restarting to upload" or restarts the service.doctorreports a stopped service as skipped instead of starting it.telemetry_ossis"on".connected_modehelper.Behavior changes to note
prompt_storage: defaultbut no HTTP notes backend will stop uploading until they runautter onboard --connect. Their status line already said "off".Not in this PR
whoamisays "off" if and only if nothing is uploaded.Lint, fmt and tests were not run locally; CI is the first check.
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.