Fix/issue 2833 - Display a notice to use 9 digit zip code for more accurate tax calculation#2835
Open
Fix/issue 2833 - Display a notice to use 9 digit zip code for more accurate tax calculation#2835
Conversation
dustinparker
reviewed
Jan 9, 2025
Collaborator
dustinparker
left a comment
dustinparker
left a comment
There was a problem hiding this comment.
Everything is looking good and works on both classic/blocks cart/checkout already. I've just left some questions/comments for potential improvements.
| * | ||
| * @param string|array $message Error message. | ||
| */ | ||
| public function _notice( $message ) { |
Collaborator
There was a problem hiding this comment.
Is there a reason for the function _ prefix?
| * @param string|array $message Error message. | ||
| */ | ||
| public function _notice( $message ) { | ||
| $formatted_message = is_scalar( $message ) ? $message : wp_json_encode( $message ); |
Collaborator
There was a problem hiding this comment.
Do we want to accept scalar values for the notice message? Or should we only be accepting strings?
Collaborator
There was a problem hiding this comment.
Could you please review how we are using the core/notices store and the wc/checkout/shipping-address notice context to fine tune where we are adding the notice and see if we can take the same approach here instead of creating a more custom kind of notice?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Displaying an error notice to let the user know that 9 digit zip code is recommended for more accurate tax calculation.
Related issue(s)
Fixes #2833
Steps to reproduce & screenshots/GIFs
Checklist
changelog.txtentry addedreadme.txtentry added