Fix: Add priority to 'shipping_phone' checkout field#1543
Open
brandomeniconi wants to merge 1 commit intoAutomattic:trunkfrom
Open
Fix: Add priority to 'shipping_phone' checkout field#1543brandomeniconi wants to merge 1 commit intoAutomattic:trunkfrom
brandomeniconi wants to merge 1 commit intoAutomattic:trunkfrom
Conversation
add the priority key to the 'shipping_phone' field in 'add_shipping_phone_to_checkout' function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My dev site is showing many notices in the WooCommerce checkout page:
Notice: Undefined index: priority in [..]/plugins/woocommerce/includes/wc-core-functions.php on line 1535By tracing down the issue I found that this plugin didn't specify a priority for the
shipping_phonefield it adds to the shipping form in theadd_shipping_phone_to_checkout. This causes PHP notices when WooCommerce tries to compare the fields priority indexes.This PR add the priority key to the field, killing the warnings.