This repository was archived by the owner on Jul 20, 2018. It is now read-only.
Warn on escape issues#249
Open
stevegrunwell wants to merge 3 commits intoAutomattic:masterfrom
stevegrunwell:warn-on-escape-issues
Open
Warn on escape issues#249stevegrunwell wants to merge 3 commits intoAutomattic:masterfrom stevegrunwell:warn-on-escape-issues
stevegrunwell wants to merge 3 commits intoAutomattic:masterfrom
stevegrunwell:warn-on-escape-issues
Conversation
…function, which would cause the output to be un-escaped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Though I hate to admit it, this check actually came from personal experience: I needed to add some additional escaping per WordPress.com VIP's feedback, but I ended up with something like
<?php esc_url( the_permalink() ); ?>, where the URL being output wasn't actually being escaped viaesc_url().Pull-request also adds tests for current
EscapingCheckclass.