[VIP-2845] Add agent documentation and skills infrastructure#48
[VIP-2845] Add agent documentation and skills infrastructure#48abdullah-kasim wants to merge 6 commits intotrunkfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a structured “agent docs” + “skills” layer intended to reduce initial AI context while keeping task-specific guidance discoverable (AGENTS.md → agent_docs/ + .agents/skills).
Changes:
- Added
AGENTS.mdas the entrypoint for agent task discovery and “learning mode” memory capture. - Added
agent_docs/topic docs covering architecture, commands, testing, linting, dev environment, feedback loops, and visual verification. - Added
.agents/skills/*markdown skills plus local-only overrides via.gitignore, and aCLAUDE.mdredirect.
Reviewed changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| agent_docs/visual-verification.md | Documents REST and browser-based verification workflows. |
| agent_docs/testing.md | Documents PHPUnit conventions and test-running commands. |
| agent_docs/linting.md | Documents when/how to run linting and fix workflows. |
| agent_docs/feedback-loops.md | Defines a verification routing table/checklist for changes. |
| agent_docs/dev-environment.md | Captures vip dev-env usage, logs, DB, shell, and cron commands. |
| agent_docs/commands.md | Central reference for build/lint/test/dev commands. |
| agent_docs/coding.md | States coding principles and “no unrelated refactors” rule. |
| agent_docs/architecture.md | Summarizes repo layout and key modules/entry points. |
| agent_docs/MEMORY/.keep | Keeps the memory directory present in git. |
| CLAUDE.md | Redirects readers to AGENTS.md. |
| AGENTS.md | Agent entrypoint: discovery steps + learning mode memory format. |
| .gitignore | Ignores local agent overrides and the local Claude skills symlink. |
| .agents/skills/update-agent-context/SKILL.md | Skill instructions for updating agent docs/memory. |
| .agents/skills/setup-claude/SKILL.md | One-time setup steps for local .claude/skills symlink. |
| .agents/skills/lint/SKILL.md | Skill instructions for running formatter/lint/type checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Use browser automation to navigate to the dev site and visually verify UI changes. | ||
| Two tools are available: | ||
|
|
||
| **1. Claude Chrome integration** (`mcp__claude-in-chrome__*`): |
There was a problem hiding this comment.
Nitpick: we could also add Firefox MCP/Chrome DevTools MCP. They were quite useful in testing stuff.
There was a problem hiding this comment.
Those tools are more for debugging?
But that said, I don't have experience with either MCP tools, so maybe a good time to pick it up - I can see smaller feedback loops can be formed with those MCPs.
There was a problem hiding this comment.
To me Claude Chrome equals using Chrome MCP, whereas Agent Browser feels more of a "drop-in", but at the end of the day, IMO they're all tools that the agent can use/rely to test the output. If we think about isolated environments then Agent Browser probably excels, but if we're thinking about local machines, then I think Claude Chrome (which is model-specific) could be sided with Firefox/Chrome MCP to make sure this is model-agnostic, that's how I was thinking about it.
| @@ -0,0 +1,105 @@ | |||
| # Dev Environment | |||
There was a problem hiding this comment.
here we could probably add an example on how to populate the env.php file locally so that the agent can add custom values to test in the WP Admin settings and in the site page.
Description
This is a PR that adds AGENTS.md and some placeholder-ish skills.
Only way to test this is kinda to just develop a feature. Do not expect a perfect recollection from Claude from this, but do expect that the context that the AI has to initially hold become a lot smaller compared to putting everything in
CLAUDE.md. Also, expect good recollection when you ask it to do one thing that matches theagent_docs, or if you referenceagent_docsdirectly. It's almost like skills, but skills are actions, and these are more like memory files. Lastly, expect better code quality due to the smaller initial context 😊My usual workflow would be:
Okay, add tests!Okay I see some issue here, (show screenshot, paste json, etc) etc. Can you fix it and use a feedback loop?I can only tell you that this has been my workflow for 2 months, and I haven't changed it. So the fact that I didn't change my workflow is amazing enough - I used to keep trying something new every 1 or 2 weeks, trying to make Claude remember. The only thing I stripped off from my actual workflow, is the YOLO mode notice, the auto-git-commit (in my actual workflow, the agent will commit on EVERY edit), and the communication style.
This workflow was based on https://href.li/?https://www.humanlayer.dev/blog/writing-a-good-claude-md .
Anyway, back to the PR, here's a few descriptions of the file added by this PR:
Universal layer (committed, works for any agent — Codex, CI, Claude):
AGENTS.md— entry point with pre-task discovery and learning mode. As small as possible to reduce initial context size.CLAUDE.md— one-liner redirect to AGENTS.mdagent_docs/— topic files:architecture.md— directory structure, key modules, entry pointscommands.md— build, lint, test, dev commands with exact flagscoding.md— code principles and ruleslinting.md— PHP/JS lint fix workflowstesting.md— PHPUnit conventions, runner, file patternsfeedback-loops.md— verification routing table (types → logs → CLI → REST → visual → tests → lint)dev-environment.md— vip dev-env setup, WP-CLI, logs, database, shell, cronvisual-verification.md— REST API testing and browser automation (Claude Chrome + agent-browser)MEMORY/*- Memory folder for the agent to auto-save what they've learned.Skills (committed under
.agents/skills/):lint/SKILL.md— PHP + JS lint commandssetup-claude/SKILL.md— one-time.claude/skillssymlink setupupdate-agent-context/SKILL.md— instructions for updating agent docsPersonal layer (gitignored via
.gitignoreupdates):CLAUDE.local.md,agent_docs_local/,.claude/skillssymlinkPre-review checklist