Skip to content

Retain source Image/Canvas in CanvasPattern so the cairo surface stays valid #2583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iurisilvio wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −0
Open

Retain source Image/Canvas in CanvasPattern so the cairo surface stays valid #2583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/CanvasPattern.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ Pattern::Pattern(const Napi::CallbackInfo& info) : ObjectWrap<Pattern>(info), en
return;
}
_pattern = cairo_pattern_create_for_surface(surface);
_source = Napi::Persistent(obj);

if (info[1].IsString()) {
if ("no-repeat" == info[1].As<Napi::String>().Utf8Value()) {
Expand Down Expand Up @@ -127,3 +128,7 @@ repeat_type_t Pattern::get_repeat_type_for_cairo_pattern(cairo_pattern_t *patter
Pattern::~Pattern() {
if (_pattern) cairo_pattern_destroy(_pattern);
}

void Pattern::Finalize(Napi::Env env) {
_source.Reset();
}
2 changes: 2 additions & 0 deletions src/CanvasPattern.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,10 @@ class Pattern : public Napi::ObjectWrap<Pattern> {
static repeat_type_t get_repeat_type_for_cairo_pattern(cairo_pattern_t *pattern);
inline cairo_pattern_t *pattern(){ return _pattern; }
~Pattern();
void Finalize(Napi::Env env);
Napi::Env env;
private:
cairo_pattern_t *_pattern;
Napi::Reference<Napi::Object> _source;
repeat_type_t _repeat = REPEAT;
};