perf(core): cache Wier ASTs#2584
Merged
elijah-potter merged 3 commits intoAutomattic:masterfrom Jan 26, 2026
Merged
Conversation
Use `Arc` to avoid cloning `weir_code` a second time on the uncached path.
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Feb 6, 2026
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v1.5.1` → `v1.6.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>Automattic/harper (Automattic/harper/harper-ls)</summary> ### [`v1.6.0`](https://github.com/Automattic/harper/releases/tag/v1.6.0) [Compare Source](Automattic/harper@v1.5.1...v1.6.0) #### What's Changed - refactor(brill): remove `lazy_static` dependency by [@​86xsk](https://github.com/86xsk) in [#​2571](Automattic/harper#2571) - feat: afterall → after all by [@​hippietrail](https://github.com/hippietrail) in [#​2582](Automattic/harper#2582) - perf(core): cache Wier ASTs by [@​86xsk](https://github.com/86xsk) in [#​2584](Automattic/harper#2584) - deps(cli): bump ariadne from 0.4.1 to 0.6.0 by [@​86xsk](https://github.com/86xsk) in [#​2577](Automattic/harper#2577) - feat: prev → previous by [@​hippietrail](https://github.com/hippietrail) in [#​2598](Automattic/harper#2598) - build(deps): bump uuid from 1.19.0 to 1.20.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2595](Automattic/harper#2595) - fix: confusing wording in `OneOfTheSingular` by [@​hippietrail](https://github.com/hippietrail) in [#​2586](Automattic/harper#2586) - feat: as of currently→ currently / as of now by [@​hippietrail](https://github.com/hippietrail) in [#​2599](Automattic/harper#2599) - chore: add words/annotations to curated dict by [@​86xsk](https://github.com/86xsk) in [#​2570](Automattic/harper#2570) - feat: nor I would→nor would I by [@​hippietrail](https://github.com/hippietrail) in [#​2590](Automattic/harper#2590) - build(deps): bump sysinfo from 0.37.2 to 0.38.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2594](Automattic/harper#2594) - fix(chrome-ext): Draft.js multiline suggestion replacement corruption by [@​draphy](https://github.com/draphy) in [#​2597](Automattic/harper#2597) - fix: `rm` old vscode versions after `just test-vscode` by [@​hippietrail](https://github.com/hippietrail) in [#​2574](Automattic/harper#2574) - fix(chrome-ext): force visibility on Reddit by [@​elijah-potter](https://github.com/elijah-potter) in [#​2603](Automattic/harper#2603) - docs(chrome-ext): notify users that Harper will clash with Gmail's grammar checker by [@​elijah-potter](https://github.com/elijah-potter) in [#​2605](Automattic/harper#2605) - feat: yea/yeh →yeah by [@​hippietrail](https://github.com/hippietrail) in [#​2604](Automattic/harper#2604) - fix(obsidian-plugin): postpone initialization until layout is ready by [@​Vinzent03](https://github.com/Vinzent03) in [#​2611](Automattic/harper#2611) - feat: no only is there → not only is there by [@​hippietrail](https://github.com/hippietrail) in [#​2610](Automattic/harper#2610) - feat(chrome-ext): enable use of the CSS Custom Highlights API for Firefox by [@​elijah-potter](https://github.com/elijah-potter) in [#​2607](Automattic/harper#2607) - refactor(core): adjustments in `Number` by [@​86xsk](https://github.com/86xsk) in [#​2591](Automattic/harper#2591) - feat(core): write rule to correct `cybersec` -> `cybersecurity` by [@​elijah-potter](https://github.com/elijah-potter) in [#​2613](Automattic/harper#2613) - fix(chrome-ext): improve test reliability by [@​elijah-potter](https://github.com/elijah-potter) in [#​2615](Automattic/harper#2615) - feat: try one‘s hands at→try one‘s hand at by [@​hippietrail](https://github.com/hippietrail) in [#​2614](Automattic/harper#2614) - feat(core): add `allows` keyword to Weir by [@​elijah-potter](https://github.com/elijah-potter) in [#​2602](Automattic/harper#2602) - build(deps): bump clap from 4.5.54 to 4.5.56 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2641](Automattic/harper#2641) - Flash in the pans -> Flashes in the pan by [@​hippietrail](https://github.com/hippietrail) in [#​2621](Automattic/harper#2621) - chore: curate dictionary by [@​hippietrail](https://github.com/hippietrail) in [#​2580](Automattic/harper#2580) - feat: go at war → go to war by [@​hippietrail](https://github.com/hippietrail) in [#​2646](Automattic/harper#2646) - fix(chrome-ext): preserve cursor position in generic contenteditable replacement by [@​draphy](https://github.com/draphy) in [#​2617](Automattic/harper#2617) - feat: peak behind the curtain→peek behind the curtain by [@​hippietrail](https://github.com/hippietrail) in [#​2635](Automattic/harper#2635) - fix: AsciiDoc support by [@​mcecode](https://github.com/mcecode) in [#​2633](Automattic/harper#2633) - build(deps): bump bytes from 1.10.1 to 1.11.1 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2647](Automattic/harper#2647) - docs: add Tally to section for projects using Harper by [@​twocaretcat](https://github.com/twocaretcat) in [#​2645](Automattic/harper#2645) - feat(core): improve debug formatting for `Suggestion` by [@​86xsk](https://github.com/86xsk) in [#​2619](Automattic/harper#2619) - refactor(core): adjustments in lexing code by [@​86xsk](https://github.com/86xsk) in [#​2618](Automattic/harper#2618) - feat: look one's nose down→look down one's nose by [@​hippietrail](https://github.com/hippietrail) in [#​2644](Automattic/harper#2644) - feat(core): introduce Weirpacks by [@​elijah-potter](https://github.com/elijah-potter) in [#​2491](Automattic/harper#2491) - fix(lint-framework): preserve cursor position in textarea after applying suggestion by [@​draphy](https://github.com/draphy) in [#​2650](Automattic/harper#2650) - feat: like no tomorrow → like there's no tomorrow by [@​hippietrail](https://github.com/hippietrail) in [#​2652](Automattic/harper#2652) - build(test): improve test build time by [@​86xsk](https://github.com/86xsk) in [#​2648](Automattic/harper#2648) - refactor(core): use a macro and document the methods by [@​elijah-potter](https://github.com/elijah-potter) in [#​2655](Automattic/harper#2655) - build: `panic = abort` and `lto = fat` for release by [@​86xsk](https://github.com/86xsk) in [#​2572](Automattic/harper#2572) - refactor(harper.js): we do not need named types for Weirpacks by [@​elijah-potter](https://github.com/elijah-potter) in [#​2657](Automattic/harper#2657) #### New Contributors - [@​twocaretcat](https://github.com/twocaretcat) made their first contribution in [#​2645](Automattic/harper#2645) **Full Changelog**: <Automattic/harper@v1.5.1...v1.6.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi45NS4yIiwidXBkYXRlZEluVmVyIjoiNDIuOTUuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6Om1pbm9yIl19-->
hippietrail
pushed a commit
to hippietrail/harper
that referenced
this pull request
Feb 20, 2026
* perf(core): cache Wier ASTs * refactor(core): appease Clippy (type complexity) * perf(core): use `Arc` to avoid double clone Use `Arc` to avoid cloning `weir_code` a second time on the uncached path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Caches Weir ASTs to avoid reparsing and improve performance.
This improves performance on the
lint_essay_uncachedbench by ~20%, and reduces the amount of time it takes to runcargo testby (roughly) ~10%.How Has This Been Tested?
cargo testcargo benchChecklist