Validate unique Tag IDs for DFP Async provider#190
Merged
Conversation
DFP Async uses the tag_id field as a div ID in the rendered HTML. When two ad codes share the same tag_id, Google's ad serving becomes confused because the same element ID appears multiple times on the page. This adds validation that prevents saving ad codes with duplicate tag_id values. The implementation uses a new 'acm_validate_ad_code' filter that providers can hook into for custom validation, keeping the solution extensible for other providers that may need similar checks. Fixes #69 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
GaryJones
force-pushed
the
fix/69-dfp-async-unique-tag-validation
branch
from
008be00 to
2ea1751
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
acm_validate_ad_codefilter for provider-specific validationDFP Async uses Tag ID as a div ID in the rendered HTML. Duplicate IDs cause Google's ad serving to malfunction because the same element ID appears multiple times on the page.
Test plan
composer test:integrationFixes #69
🤖 Generated with Claude Code