Open
Conversation
Repeated delegate cancellations could keep triggering later queue checks and leak extra expectation fulfills into subsequent tests. Wait for `didFinishUploadingLog` before asserting the successful upload callback path. --- Generated with the help of Codex, https://openai.com Co-Authored-By: Codex <noreply@openai.com>
Add brief comments around the delegate pause flow and the two-step test expectation so the flaky-test fix is easier to follow. --- Generated with the help of Codex Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, I noticed the Mac tests being flaky in CI. I got Codex to look into it and this seems like a decent way to address the issue.
Summary
didFinishUploadingLogin the upload manager success test before asserting completionTesting
Created #329 with
100parallel test builds. All green