Merged
Conversation
An interrupted write to assignments.json (e.g. app killed mid-write) leaves an empty or truncated file. On next launch, Moshi throws EOFException parsing it, which propagates out of the FileBasedCache init coroutine and crashes the app in a loop that Clear Cache cannot fix (file lives in filesDir, not cacheDir). - Treat empty files as a cache miss and delete them - Catch JSON parse failures, log and delete the corrupted file - Wrap the init block's coroutine in runCatching so any future read failure degrades gracefully instead of crashing the process
Preserves stack traces in logs when cache reads fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge this draft PR, it only usage is to trigger the CI checks associated to its external contributor (ish) related PR (#297).