Fix bug: Remove incorrect quotation Marks in Java Command Paths#168
Closed
jonatanwestling wants to merge 1 commit intoAutomatedProcessImprovement:masterfrom
Closed
Fix bug: Remove incorrect quotation Marks in Java Command Paths#168jonatanwestling wants to merge 1 commit intoAutomatedProcessImprovement:masterfrom
jonatanwestling wants to merge 1 commit intoAutomatedProcessImprovement:masterfrom
Conversation
|
|
I am having the same error |
Collaborator
|
Hello @jonis1337 and @davidsequera , Thanks for pointing out this bug! And sorry for the delay in the fix. We included the double quotes to support Windows paths with spaces, and forgot to cover the UNIX alternative in the case of the BPMN layout (we did cover it when running SplitMiner jar). I added a fix in the latest PR (#171) so that it covers both cases depending on the platform. Please, reopen if the error persists. |
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



When running Simod in a Docker container with complete_configuration.yml, the Java command for BPMN layout generation fails due to quotation marks (") around file paths. The error occurs when executing the bpmn-layout-1.0.6-jar-with-dependencies.jar command, resulting in:
Adding BPMN diagram to the model: ['java', '-jar', '"/usr/src/Simod/src/simod/control_flow/lib/bpmn-layout-1.0.6-jar-with-dependencies.jar"', '"/usr/src/Simod/outputs/20250428_211724_A07E83B1_0E85_45DD_B8C1_422790F8FEB1/best_result/LoanApp_simplified_train.bpmn"']
Error: Unable to access jarfile "/usr/src/Simod/src/simod/control_flow/lib/bpmn-layout-1.0.6-jar-with-dependencies.jar"
This happens because the quotation marks are incorrectly included in the command, causing the Java runtime to misinterpret the JAR file path. When removing the quotation mark around the paths, the command runs successfully if the modified source code is mounted.
To reproduce this bug just follow the Docker guide in the readme file in the repo and run with complete_configuration.yml (havent tried with the others). And the error message should be displayed at the end.