Skip to content

Conversation

@sankalps0549
Copy link
Collaborator

Description

This PR is responsible for removing the metadata file from the integration tests as discussed.

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the documentation accordingly
  • I have added a note to CHANGELOG.md describing my changes
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Data Generation

image

Testing

python run.py test --integration

The following is a snippet of all integration tests run:
image
image
image
image
image
image

  • The xfailed test is a known issue so we are skipping the test.
  • The deselected tests are the unit and core tests.

@sankalps0549 sankalps0549 requested a review from Copilot December 14, 2025 17:49
@sankalps0549 sankalps0549 self-assigned this Dec 14, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the metadata tracking system from integration tests, eliminating the metadata.json file and all related functionality. The change simplifies the test data generation process by removing timestamp and version tracking that was previously recorded when generating baseline test data.

Key changes:

  • Removed metadata.json file containing test data generation timestamps and version information
  • Eliminated metadata-related constants, classes, and helper functions
  • Renamed command from generate-baseline-data to generate-expected-data for clarity

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/api/integration_tests/metadata.json Deleted metadata file that tracked generation timestamps and build versions
tests/api/integration_tests/data_generation/generate_data_logger.py Removed metadata file tracking from logger
tests/api/integration_tests/data_generation/generate_data_helper.py Removed Metadata class, fetch_metadata function, and metadata handling from commit_data function
tests/api/integration_tests/data_generation/generate_data.py Removed datetime imports and DATE_TIME parameter from data generation calls
tests/api/integration_tests/constants.py Removed metadata-related constants (file paths and date/time format strings)
tests/api/integration_tests/README.md Removed metadata tracking documentation section and all references to metadata.json
run.py Renamed command from generate-baseline-data to generate-expected-data

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@osinjoku osinjoku merged commit be643bb into feature/integration-tests Dec 16, 2025
19 checks passed
@osinjoku osinjoku deleted the infra-update-remove-metadata branch December 16, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants