Skip to content
This repository was archived by the owner on Aug 1, 2025. It is now read-only.

Add GITHUB_PROTOCOL support (http or https)#7

Closed
jokram wants to merge 1 commit intoAutodesk:masterfrom
jokram:feature/configurable-protocol
Closed

Add GITHUB_PROTOCOL support (http or https)#7
jokram wants to merge 1 commit intoAutodesk:masterfrom
jokram:feature/configurable-protocol

Conversation

@jokram
Copy link
Copy Markdown

@jokram jokram commented Jan 17, 2017

In my company the GitHub Enterprise server is (currently) running with http.
So I've tried to make this configurable by 2 new variables in enterprise.constants:

  • GITHUB_PROTOCOL: default set to https
  • GITHUB_URL: contains the protocol + server

@larsxschneider
Copy link
Copy Markdown
Contributor

larsxschneider commented Jan 17, 2017

Looks good to me! I'll update the OSS enterprise-config with our latest internal version first and then merge your PR (this makes it easier for me the merge your change into our internal version).

Thanks a lot for the contribution! 👍

@jokram
Copy link
Copy Markdown
Author

jokram commented Jan 20, 2017

Since this branch is merged already into the other branch (see #8) and there GITHUB_PROTOCOL has been renamed to GHE_HTTP it makes sense to handle the changes from this pull request only in #8 => I will close this pull request

@jokram jokram closed this Jan 20, 2017
@jokram jokram deleted the feature/configurable-protocol branch January 20, 2017 07:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants