fix: ServerSocket leak in AutoBalancerTestUtils#findLocalPorts#3244
Merged
daniel-y merged 1 commit intoAutoMQ:mainfrom Mar 9, 2026
Merged
Conversation
iamsanjaymalakar
requested review from
1sonofqiu,
Gezi-lzq,
superhx and
woshigaopp
as code owners
|
|
iamsanjaymalakar
changed the title
Gezi-lzq
approved these changes
Mar 5, 2026
Contributor
Gezi-lzq
left a comment
Gezi-lzq
left a comment
There was a problem hiding this comment.
Looks good. This correctly closes the ServerSocket when an exception occurs after socket creation (e.g. during setReuseAddress), which prevents FD leaks in the test utility failure path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Fixes #3243
What changed
Ensure
ServerSocketis closed when anIOExceptionoccurs after the socket is created but before it is added to the tracking list (e.g., duringsetReuseAddress(true)).Why
Prevents leaking file descriptors in the test utility, avoiding potential flakiness/resource exhaustion in CI.
Testing
No behavior change in the success path; only improves cleanup on failure.