fix: Reset partCount in StreamObjectCompactor to prevent inefficient grouping#3130
Open
Bablusinghnirwan wants to merge 1 commit intoAutoMQ:mainfrom
Open
fix: Reset partCount in StreamObjectCompactor to prevent inefficient grouping#3130Bablusinghnirwan wants to merge 1 commit intoAutoMQ:mainfrom
Bablusinghnirwan wants to merge 1 commit intoAutoMQ:mainfrom
Conversation
…mpactor This fixes a bug where the part count was not reset for new groups, potentially causing inefficient compaction.
Bablusinghnirwan
requested review from
1sonofqiu,
Gezi-lzq,
superhx and
woshigaopp
as code owners
|
|
|
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a logic bug in StreamObjectCompactor.java where the
partCountaccumulator was not being reset when creating a new object group.Why is it needed?
Currently,
partCountkeeps increasing indefinitely because it isn't cleared when group andgroupSizeare reset.This causes the condition
partCount + objectPartCount > Writer.MAX_PART_COUNTto fail prematurely for all subsequent groups after the first one. As a result, valid large groups are split unnecessarily into smaller chunks, leading to inefficient compaction.partCount = 0;inside the group initialization block inStreamObjectCompactor#group0.