Skip to content

[PHB24] Spells #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MeriadarGoblin wants to merge 79 commits into
base: phb2024
Choose a base branch
from
Open

[PHB24] Spells #291

MeriadarGoblin wants to merge 79 commits into from

Conversation

@MeriadarGoblin
Copy link
Contributor

@MeriadarGoblin MeriadarGoblin commented Nov 22, 2024

Created spells with help from Tregolani.

tregolani
tregolani reviewed Dec 3, 2024
View reviewed changes
tregolani
tregolani reviewed Dec 31, 2024
View reviewed changes
tregolani
tregolani suggested changes Feb 25, 2025
View reviewed changes
Copy link

@tregolani tregolani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class list corrections to a handful of spells

@MeriadarGoblin MeriadarGoblin self-assigned this Mar 3, 2025
MeriadarGoblin and others added 24 commits March 3, 2025 14:52
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
55ca1b5 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
991b36d 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
5c4bffc 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
98899b3 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
09a8992 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
a96825f 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
45c5910 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
137007f 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
aac0841 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
004779f 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
2a25f0b 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
78aaae6 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
930d57e 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
02d1ea9 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
4bfc917 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
662c8f8 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
d388555 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
8d6bd5f 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
1a9cbc9 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
ba300d5 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
7e31cee 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
d96b0c5 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
181c32d 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
@MeriadarGoblin @tregolani
Update core/players-handbook-2024/spells.xml
ce10b44 
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
MeriadarGoblin and others added 14 commits January 21, 2026 15:35
@MeriadarGoblin @NickVendel
Update core/players-handbook-2024/spells.xml
a15e887 
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
@MeriadarGoblin @NickVendel
Update core/players-handbook-2024/spells.xml
90cf89a 
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
@MeriadarGoblin @NickVendel
Update core/players-handbook-2024/spells.xml
05a3ba9 
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
@MeriadarGoblin @NickVendel
Update core/players-handbook-2024/spells.xml
8dcbf0f 
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
@MeriadarGoblin @NickVendel
Update core/players-handbook-2024/spells.xml
500bd59 
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
@MeriadarGoblin @NickVendel
Update core/players-handbook-2024/spells.xml
08827b1 
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
@MeriadarGoblin @NickVendel
Update core/players-handbook-2024/spells.xml
215549f 
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
@MeriadarGoblin @NickVendel
Update core/players-handbook-2024/spells.xml
304ea09 
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
@MeriadarGoblin @NickVendel
Update core/players-handbook-2024/spells.xml
9e1b07f 
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
@MeriadarGoblin @NickVendel
Update core/players-handbook-2024/spells.xml
787f305 
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
@MeriadarGoblin @NickVendel
Update core/players-handbook-2024/spells.xml
e3346a6 
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
@MeriadarGoblin @NickVendel
Update core/players-handbook-2024/spells.xml
3b92cc1 
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
@MeriadarGoblin @NickVendel
Update core/players-handbook-2024/spells.xml
499d005 
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
@MeriadarGoblin @NickVendel
Update core/players-handbook-2024/spells.xml
2fc8e5f 
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
@Krishna-Sivakumar
Copy link

Krishna-Sivakumar commented Jan 22, 2026

The Astral Projection spell is missing a closing description tag and one of its setters was misconfigured when I tried testing this PR

@NickVendel
Copy link
Contributor

NickVendel commented Jan 22, 2026 •
edited
Loading

The Astral Projection spell is missing a closing description tag and one of its setters was misconfigured when I tried testing this PR

@Krishna-Sivakumar yeah, i can see that, seems to happen when Meriadar was doing suggestions, but it's likely the issue with Github, lately we have a massive problem of dealing with it... so i assume something gone wrong there. We gonna try to fix it today. In the worse case scenario we'll just recreate this PR with new files.
Though not sure what you mean by "misconfigured", as far as i can tell, everything is correct in that regard.

@Krishna-Sivakumar
Copy link

Krishna-Sivakumar commented Jan 22, 2026 •
edited
Loading

@NickVendel I'm not sure either, Aurora complained about a setting within the spell, and I'm finding it hard to wipe Aurora's content sources to reproduce it.

@NickVendel
Copy link
Contributor

NickVendel commented Jan 22, 2026

@Krishna-Sivakumar what version of the app are you using?

@Krishna-Sivakumar
Copy link

Krishna-Sivakumar commented Jan 22, 2026

@NickVendel I downloaded it from the website today, so I think it is the latest one.

@NickVendel
Copy link
Contributor

NickVendel commented Jan 22, 2026

@Krishna-Sivakumar hm, weird, are you in any of our Discord servers?

@Krishna-Sivakumar
Copy link

Krishna-Sivakumar commented Jan 22, 2026

@NickVendel Nope, I'll let you know if I join

NickVendel and others added 5 commits January 22, 2026 15:11
@NickVendel @MeriadarGoblin @tregolani
The baseline
0865744 
Meriadar's PHB24 Spells branch at the time of commit 2fc8e5f

Co-Authored-By: MeriadarGoblin <99753019+MeriadarGoblin@users.noreply.github.com>
Co-Authored-By: tregolani <64651202+tregolani@users.noreply.github.com>
@NickVendel
My changes
4eb7fa5
@NickVendel
Merge branch 'spells-phb2024' into phb24-spells
48e2ef9
@NickVendel
Additional changes
7992a86
@MeriadarGoblin
Merge pull request #3 from NickVendel/phb24-spells
edeee9b 
Changes from my Review for your PR thx to Nick
@MeriadarGoblin MeriadarGoblin changed the base branch from master to phb2024 January 30, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickVendel NickVendel Awaiting requested review from NickVendel

@tregolani tregolani Awaiting requested review from tregolani

1 more reviewer

@FreshRoyal FreshRoyal FreshRoyal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MeriadarGoblin MeriadarGoblin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MeriadarGoblin @Krishna-Sivakumar @NickVendel @tregolani @FreshRoyal