-
Notifications
You must be signed in to change notification settings - Fork 100
[PHB24] Updated Monk file, plus Monk and Fighter subclasses #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: phb2024
Are you sure you want to change the base?
Conversation
Removed "prepared spell slots" stats (erroneously copied from PHB2024 wizard file)
Correcting file location in the info block
Added missing Replacement Feature elements for new PHB2024 features
Added missing Replacement Feature elements for new PHB2024 features
Removed Condition Immunity "Poisoned", as it is not part of the base app.
Corrected lvl 14 feature to be granted @ lvl 14 (was erroneously granted at lvl 10)
Corrected lvl 14 feature to be granted at lvl 14 (was erroneously granted at lvl 10)
5d6 Sneak Attack option in class table was erroneously listed as "Sd6"
redundant with original PR
NickVendel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fighter Subclasses review
| </info> | ||
|
|
||
| <element name="Battle Master" type="Archetype" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ARCHETYPE_FIGHTER_BATTLE_MASTER"> | ||
| <supports>Martial Archetype</supports> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <supports>Martial Archetype</supports> | |
| <supports>Fighter Subclass</supports> |
core/players-handbook-2024/archetypes/fighter-battle-master.xml
Outdated
Show resolved
Hide resolved
core/players-handbook-2024/archetypes/fighter-battle-master.xml
Outdated
Show resolved
Hide resolved
NickVendel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Monk + Monk Subclass review
Committing Nick's Battlemaster suggestions Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Committing Nick's suggestions for Champion, EK, and Psi Warrior Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Committing Nick's suggestions for monk subclasses Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Committing Nick's suggestions for monk class Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Updated with Nick's latest file
Updated with Nick's latest file
NickVendel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my file clearly had some issues, so i am fixing them in this short review
in favor of tregolani's AuroraLegacy#290 PR.
Monk file updates per Nick's review (1/30) Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Created the subclass files for Fighter and Monk, as well as an updated version of the monk class file, based on Zencha's file in their PR.