Skip to content

Conversation

@Zencha70
Copy link
Contributor

No description provided.

@Zencha70 Zencha70 changed the title [PHB24] Addition of Cleric, Fighter, Monk & Wizard classes + Cleric - Life & Trickery subclasses [PHB24] Addition of Cleric, Fighter, Monk & Wizard classes + Cleric subclasses Oct 30, 2024
@Zencha70 Zencha70 changed the title [PHB24] Addition of Cleric, Fighter, Monk & Wizard classes + Cleric subclasses [PHB24] Addition of Cleric, Fighter, Monk & Wizard classes + Cleric subclasses & Wizard - Illusionist Subclass Oct 31, 2024
@Zencha70 Zencha70 changed the title [PHB24] Addition of Cleric, Fighter, Monk & Wizard classes + Cleric subclasses & Wizard - Illusionist Subclass [PHB24] Addition of Cleric, Fighter, Monk & Wizard classes + Cleric subclasses & Wizard - Abjurer, Evoker & Illusionist Subclasses Oct 31, 2024
@Zencha70 Zencha70 changed the title [PHB24] Addition of Cleric, Fighter, Monk & Wizard classes + Cleric subclasses & Wizard - Abjurer, Evoker & Illusionist Subclasses [PHB24] Addition of Cleric, Fighter, Monk & Wizard classes + Cleric subclasses & Wizard subclasses Oct 31, 2024
@Zencha70
Copy link
Contributor Author

Zencha70 commented Oct 31, 2024

Note, all classes miss specific Epic Boon and new ASI features supports, as those have not been developed yet, so for now they have simply been granted the lvl 19 ASI improvement used in the 2014 version.

Specific spell-grants have been comment-marked, also awaiting 2024 spell ID development.
Spellcasting Classes spell lists may need to be provided Supports if exclusively 2024 spell lists are to be applied.

Feel free to add to the remaining subclasses if you have the time, energy and motivation!

@Tel0k
Copy link

Tel0k commented Nov 5, 2024

I would suggest you add _FIGHTER_ in the Fighter class features' IDs, much like you did with all other classes

Now include _FIGHTER_
Telok's got better eyes than me
(fixed ID's again)
Copy link

@tregolani tregolani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a full pass over the monk class file while I was doing the monk subclasses. I've uploaded an edited version of the file with (i think) appropriate updates. File Here

Copy link

@tregolani tregolani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and code-suggested each change I thought was necessary. Should be able to accept my suggestions and update the code fairly easily.

@Zencha70
Copy link
Contributor Author

Reviewed and code-suggested each change I thought was necessary. Should be able to accept my suggestions and update the code fairly easily.

Oh lowd, I gotta sit down and check em out when I get the time

Zencha70 and others added 3 commits November 20, 2024 12:11
Confirmed Suggestions from Tregolani

Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
Second Round Confirmed Suggestions from Tregolani

Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
Copy link
Contributor

@NickVendel NickVendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fighter class review

Comment on lines 66 to 78
<div element="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_FIGHTING_STYLE" />
<div element="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_SECOND_WIND" />
<div element="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_WEAPON_MASTERY" />
<div element="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_ACTION_SURGE" />
<div element="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_TACTICAL_MIND" />
<div element="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER__FIGHTER_SUBCLASS" />
<div element="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_ABILITY_SCORE_IMPROVEMENT" />
<div element="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_EXTRA_ATTACK" />
<div element="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_TACTICAL_SHIFT" />
<div element="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_INDOMITABLE" />
<div element="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_TACTICAL_MASTER" />
<div element="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_STUDIED_ATTACKS" />
<div element="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_EPIC_BOON" />

This comment was marked as resolved.

Comment on lines 94 to 107
<select type="Proficiency" name="Skill Proficiency (Fighter)" supports="ID_WOTC_PHB24_PROFICIENCY_SKILL_NATURE|ID_WOTC_PHB24_PROFICIENCY_SKILL_ACROBATICS|ID_WOTC_PHB24_PROFICIENCY_SKILL_ANIMALHANDLING|ID_WOTC_PHB24_PROFICIENCY_SKILL_ATHLETICS|ID_WOTC_PHB24_PROFICIENCY_SKILL_HISTORY|ID_WOTC_PHB24_PROFICIENCY_SKILL_INSIGHT|ID_WOTC_PHB24_PROFICIENCY_SKILL_INTIMIDATION|ID_WOTC_PHB24_PROFICIENCY_SKILL_PERSUASION|ID_WOTC_PHB24_PROFICIENCY_SKILL_PERCEPTION|ID_WOTC_PHB24_PROFICIENCY_SKILL_SURVIVAL" number="2" requirements="!ID_WOTC_PHB_MULTICLASS_FIGHTER"/>
<grant type="Class Feature" id="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_FIGHTING_STYLE" level="1"/>
<grant type="Class Feature" id="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_SECOND_WIND" level="1"/>
<grant type="Class Feature" id="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_WEAPON_MASTERY" level="1"/>
<grant type="Class Feature" id="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_ACTION_SURGE" level="2"/>
<grant type="Class Feature" id="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_TACTICAL_MIND" level="2"/>
<grant type="Class Feature" id="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER__FIGHTER_SUBCLASS" level="3"/>
<grant type="Class Feature" id="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_ABILITY_SCORE_IMPROVEMENT" level="4"/>
<grant type="Class Feature" id="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_EXTRA_ATTACK" level="5"/>
<grant type="Class Feature" id="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_TACTICAL_SHIFT" level="5"/>
<grant type="Class Feature" id="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_INDOMITABLE" level="9"/>
<grant type="Class Feature" id="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_TACTICAL_MASTER" level="9"/>
<grant type="Class Feature" id="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_STUDIED_ATTACKS" level="13"/>
<grant type="Class Feature" id="ID_WOTC_PHB24_CLASS_FEATURE_FIGHTER_EPIC_BOON" level="19"/>

This comment was marked as resolved.

Comment on lines 276 to 285
<p class="indent">You can use this feature twice between long rests starting at 13th level and three times between long rests starting at 17th level.</p>
</description>
<sheet alt="Indomitable" usage="{{indomitable:usage}}/Long Rest">
<description>You can reroll a saving throw that you fail with a +{{indomitable:bonus}} bonus. If you do so, you must use the new roll.</description>
</sheet>
<rules>
<stat name="indomitable:usage" value="1" level="9" />
<stat name="indomitable:usage" value="1" level="13" />
<stat name="indomitable:usage" value="1" level="17" />
<stat name="indomitable:bonus" value="level:fighter" />

This comment was marked as resolved.

<description>When you attack with a weapon whose mastery property you can use, you can replace that property with the Push, Sap or Slow property for that attack.</description>
</sheet>
</element>

This comment was marked as resolved.

Comment on lines 302 to 305
<p>You study your opponents and learn from each attack you make. If you make an attack roll against a creature and miss, you have Advantage on your next attack roll against that creaure before the end of your next turn.</p>
</description>
<sheet alt="Studied Attacks">
<description>If you miss with an attack roll, you have Advantage on your next attack roll against that creature before the end of your next turn.</description>

This comment was marked as resolved.

Comment on lines 318 to 320

</rules>
</element>

This comment was marked as resolved.

Comment on lines 333 to 336
<element name="Tactical Master Feature Replacement" type="Grants" source="Internal" id="ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_FIGHTER_TACTICAL_MASTER" />
<element name="Studied Attacks Feature Replacement" type="Grants" source="Internal" id="ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_FIGHTER_STUDIED_ATTACKS" />
<element name="Epic Boon Feature Replacement" type="Grants" source="Internal" id="ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_FIGHTER_EPIC_BOON" />

This comment was marked as resolved.

Zencha70 and others added 3 commits April 11, 2025 18:16
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Copy link
Contributor

@NickVendel NickVendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wizard Review

Comment on lines 42 to 52
<h5 class="caption">WIZARD FEATURES</h5>
<table class="class-features">
<tr style="font-weight: bold">
<td rowspan="2">Level</td>
<td class="col-20 left" rowspan="2">Class Features</td>
<td rowspan="2">Prepared<br />Spells</td>
<td rowspan="2">Cantrips</td>
<td colspan="9" style="vertical-align:bottom; border-bottom: 0px">Spell Slots per Level</td>
</tr>
<tr style="font-weight: bold"><td>1</td><td>2</td><td>3</td><td>4</td><td>5</td><td>6</td><td>7</td><td>8</td><td>9</td></tr>
<tr><td> 1</td><td class="left">Spellcasting, Ritual Adept, Arcane Recovery</td><td>4</td><td>3</td><td>2</td><td>—</td><td>—</td><td>—</td><td>—</td><td>—</td><td>—</td><td>—</td><td>-</td></tr>

This comment was marked as resolved.

<grant type="Spell" id="ID_WOTC_PHB24_SPELL_SUMMON_BEAST" spellcasting="Wizard" prepared="true" />
<grant type="Spell" id="ID_WOTC_PHB24_SPELL_SUMMON_FEY" spellcasting="Wizard" prepared="true" />
</rules>

This comment was marked as resolved.

Comment on lines 84 to 85
</element>
<element name="Level 10: Illusory Self" type="Archetype Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ARCHETYPE_WIZARD_ILLUSIONIST_ILLUSORY_SELF">

This comment was marked as resolved.

Comment on lines 94 to 95
</element>
<element name="Level 14: Illusory Reality" type="Archetype Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_ARCHETYPE_WIZARD_ILLUSIONIST_ILLUSORY_REALITY">

This comment was marked as resolved.

<element name="Malleable Illusions Feature Replacement" type="Grants" source="Internal" id="ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_WIZARD_ILLUSIONIST_PHANTASMAL_CREATURES" />
<element name="Illusory Self Feature Replacement" type="Grants" source="Internal" id="ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_WIZARD_ILLUSIONIST_ILLUSORY_SELF" />
<element name="Illusory Reality Feature Replacement" type="Grants" source="Internal" id="ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_WIZARD_ILLUSIONIST_ILLUSORY_REALITY" />
</elements> No newline at end of file

This comment was marked as resolved.

Zencha70 and others added 5 commits May 12, 2025 19:15
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Extended review integration from @NickVendel

Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
</description>
<sheet display="false" />
<rules>
<select type="Class Feature" name="Sacred Role (Divine Domain)" supports="PHB24 Divine Order" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<select type="Class Feature" name="Sacred Role (Divine Domain)" supports="PHB24 Divine Order" />
<select type="Class Feature" name="Divine Order" supports="PHB24 Divine Order" />

Divine Domain was the old name for the Cleric Subclass, not this feature. Other than the descriptive text, I can't see any reference to 'Sacred Role' as the name of this feature?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sacred Role is what you're choosing. "You have dedicated yourself to one of the following sacred roles of your choice."
Divine Domain part was likely my mistake. This should probably be fixed to following:

Suggested change
<select type="Class Feature" name="Sacred Role (Divine Domain)" supports="PHB24 Divine Order" />
<select type="Class Feature" name="Sacred Role (Divine Order)" supports="PHB24 Divine Order" />

Comment on lines +332 to +334
<rules>
<select type="Class Feature" name="Blessed Strikes" supports="ID_WOTC_PHB24_CLASS_FEATURE_CLERIC_BLESSED_STRIKES_DIVINE_STRIKE|ID_WOTC_PHB24_CLASS_FEATURE_CLERIC_BLESSED_STRIKES_POTENT_SPELLCASTING" />
</rules>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<rules>
<select type="Class Feature" name="Blessed Strikes" supports="ID_WOTC_PHB24_CLASS_FEATURE_CLERIC_BLESSED_STRIKES_DIVINE_STRIKE|ID_WOTC_PHB24_CLASS_FEATURE_CLERIC_BLESSED_STRIKES_POTENT_SPELLCASTING" />
</rules>
<rules>
<select type="Class Feature" name="Blessed Strikes" supports="ID_WOTC_PHB24_CLASS_FEATURE_CLERIC_BLESSED_STRIKES_DIVINE_STRIKE|ID_WOTC_PHB24_CLASS_FEATURE_CLERIC_BLESSED_STRIKES_POTENT_SPELLCASTING" />
<grant type="Class Feature" id="ID_INTERNAL_FEATURE_REPLACEMENT_CLERIC_DIVINE_STRIKE_OR_POTENT_SPELLCASTING" level="7"/>
</rules>

This will stop the Divine Strike/Potent Spellcasting feature from old subclasses from being applied

Copy link
Contributor

@NickVendel NickVendel Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing it this way might lead to issues in the future. We would have to tested it first. Also, there's unnecessary spaces before the grant and type of the element you're trying to use is Grants rather than Class Feature

<p class="indent">You roll an additional d8 when you reach Cleric levels 7 (2d8), 13 (3d8), and 18 (4d8).</p>
<p class="indent"><b><i>Turn Undead.</i></b> As a Magic action, you present your Holy Symbol and censure Undead creatures. Each Undead of your choice within 30 feet of you must make a Wisdom saving throw. If the creature fails its save, it has the Frightened and Incapacitated conditions for 1 minute. For that duration, it tries to move as far from you as it can on its turns. This effect ends early on the creature if it takes any damage, if you have the Incapacitated condition, or if you die.</p>
</description>
<sheet alt="Channel Divinity" usage="{{channel divinity:count}}/Long Rest" >

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<sheet alt="Channel Divinity" usage="{{channel divinity:count}}/Long Rest" >
<sheet alt="Channel Divinity" usage="{{channel divinity:count}}/Regain 1/Short Rest and all on a Long Rest" >

Or whatever wording you can think of is more succinct to get this across?

<p>As a Magic action, you point your Holy Symbol at another creature you can see within 30 feet of yourself and focus divine energy at it. Roll 1d8 and add your Wisdom modifier. You either restore Hit Points to the creature equal to that total or force the creature to make a Constitution saving throw. On a failed save, the creature takes Necrotic or Radiant damage (your choice) equal to that total. On a successful save, the creature takes half as much damage (round down).</p>
<p class="indent">You roll an additional d8 when you reach Cleric levels 7 (2d8), 13 (3d8), and 18 (4d8).</p>
</description>
<sheet alt="Divine Spark" action="Action" usage="Channel Divinity">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<sheet alt="Divine Spark" action="Action" usage="Channel Divinity">
<sheet alt="Divine Spark" action="Magic Action" usage="Channel Divinity">

Keeping with new rules, can say what type of Action is being used perhaps?

Copy link
Contributor

@NickVendel NickVendel Jun 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently within this process, we're prioritizing the main action used, as in Magic Action is just a sub-category of Action, so to use it you would spend your Action, which is more intuitive than going into specific sub-categories of actions.

<description>
<p>As a Magic action, you present your Holy Symbol and censure Undead creatures. Each Undead of your choice within 30 feet of you must make a Wisdom saving throw. If the creature fails its save, it has the Frightened and Incapacitated conditions for 1 minute. For that duration, it tries to move as far from you as it can on its turns. This effect ends early on the creature if it takes any damage, if you have the Incapacitated condition, or if you die.</p>
</description>
<sheet alt="Turn Undead" action="Action" usage="Channel Divinity">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<sheet alt="Turn Undead" action="Action" usage="Channel Divinity">
<sheet alt="Turn Undead" action="Magic Action" usage="Channel Divinity">

<stat name="channel divinity:count" value="3" level="6" bonus="base" />
<stat name="channel divinity:count" value="4" level="18" bonus="base" />
<select type="Class Feature" name="Channel Divinity: Divine Spark" supports="PHB24 Divine Spark" default="ID_WOTC_PHB24_CLASS_FEATURE_CLERIC_CHANNEL_DIVINITY_DIVINE_SPARK" requirements="!ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_CLERIC_CHANNEL_DIVINITY_DIVINE_SPARK" />
<select type="Class Feature" name="Channel Divinity: Divine Spark" supports="PHB24 Turn Undead" default="ID_WOTC_PHB24_CLASS_FEATURE_CLERIC_CHANNEL_DIVINITY_TURN_UNDEAD" requirements="!ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_CLERIC_CHANNEL_DIVINITY_TURN_UNDEAD" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<select type="Class Feature" name="Channel Divinity: Divine Spark" supports="PHB24 Turn Undead" default="ID_WOTC_PHB24_CLASS_FEATURE_CLERIC_CHANNEL_DIVINITY_TURN_UNDEAD" requirements="!ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_CLERIC_CHANNEL_DIVINITY_TURN_UNDEAD" />
<select type="Class Feature" name="Channel Divinity: Turn Undead" supports="PHB24 Turn Undead" default="ID_WOTC_PHB24_CLASS_FEATURE_CLERIC_CHANNEL_DIVINITY_TURN_UNDEAD" requirements="!ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_CLERIC_CHANNEL_DIVINITY_TURN_UNDEAD" />

<stat name="channel divinity:count" value="3" level="6" bonus="base" />
<stat name="channel divinity:count" value="4" level="18" bonus="base" />
<select type="Class Feature" name="Channel Divinity: Divine Spark" supports="PHB24 Divine Spark" default="ID_WOTC_PHB24_CLASS_FEATURE_CLERIC_CHANNEL_DIVINITY_DIVINE_SPARK" requirements="!ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_CLERIC_CHANNEL_DIVINITY_DIVINE_SPARK" />
<select type="Class Feature" name="Channel Divinity: Divine Spark" supports="PHB24 Turn Undead" default="ID_WOTC_PHB24_CLASS_FEATURE_CLERIC_CHANNEL_DIVINITY_TURN_UNDEAD" requirements="!ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_CLERIC_CHANNEL_DIVINITY_TURN_UNDEAD" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<select type="Class Feature" name="Channel Divinity: Divine Spark" supports="PHB24 Turn Undead" default="ID_WOTC_PHB24_CLASS_FEATURE_CLERIC_CHANNEL_DIVINITY_TURN_UNDEAD" requirements="!ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_CLERIC_CHANNEL_DIVINITY_TURN_UNDEAD" />
<select type="Class Feature" name="Channel Divinity: Turn Undead" supports="PHB24 Turn Undead" default="ID_WOTC_PHB24_CLASS_FEATURE_CLERIC_CHANNEL_DIVINITY_TURN_UNDEAD" requirements="!ID_INTERNAL_PHB24_FEATURE_REPLACEMENT_CLERIC_CHANNEL_DIVINITY_TURN_UNDEAD" />

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a repeat?

@Zencha70 Zencha70 changed the title [PHB24] Addition of Cleric, Fighter, Monk & Wizard classes + Cleric subclasses & Wizard subclasses [PHB24] Addition of Cleric, Fighter, Monk & Wizard classes + Cleric subclasses & Wizard subclasses & Eldritch Knight Jul 3, 2025
<list known="true">Cleric</list>
</spellcasting>
<rules>
<grant type="Grants" id="ID_INTERNAL_GRANT_MULTICLASS_SPELLCASTING_SLOTS_FULL" requirements="ID_INTERNAL_GRANT_MULTICLASS" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<grant type="Grants" id="ID_INTERNAL_GRANT_MULTICLASS_SPELLCASTING_SLOTS_FULL" requirements="ID_INTERNAL_GRANT_MULTICLASS" />
<grant type="Grants" id="ID_INTERNAL_GRANTS_SPELLCASTING_FEATURE" />
<grant type="Grants" id="ID_INTERNAL_GRANT_MULTICLASS_SPELLCASTING_SLOTS_FULL" requirements="ID_INTERNAL_GRANT_MULTICLASS" />

The way the new feats are written, some of them (such as Elemental Adept & Spell Sniper) require this grant. I've added it to all of my spellcasting class files.

<list>Wizard</list>
</spellcasting>
<rules>
<grant type="Grants" id="ID_INTERNAL_GRANT_MULTICLASS_SPELLCASTING_SLOTS_FULL" requirements="ID_INTERNAL_GRANT_MULTICLASS"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<grant type="Grants" id="ID_INTERNAL_GRANT_MULTICLASS_SPELLCASTING_SLOTS_FULL" requirements="ID_INTERNAL_GRANT_MULTICLASS"/>
<grant type="Grants" id="ID_INTERNAL_GRANTS_SPELLCASTING_FEATURE" />
<grant type="Grants" id="ID_INTERNAL_GRANT_MULTICLASS_SPELLCASTING_SLOTS_FULL" requirements="ID_INTERNAL_GRANT_MULTICLASS"/>

same as Cleric - needed for spellcasting feats

<list>Wizard</list>
</spellcasting>
<rules>
<grant type="Grants" id="ID_INTERNAL_GRANT_MULTICLASS_SPELLCASTING_SLOTS_THIRD" requirements="ID_INTERNAL_GRANT_MULTICLASS"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<grant type="Grants" id="ID_INTERNAL_GRANT_MULTICLASS_SPELLCASTING_SLOTS_THIRD" requirements="ID_INTERNAL_GRANT_MULTICLASS"/>
<grant type="Grants" id="ID_INTERNAL_GRANTS_SPELLCASTING_FEATURE" />
<grant type="Grants" id="ID_INTERNAL_GRANT_MULTICLASS_SPELLCASTING_SLOTS_THIRD" requirements="ID_INTERNAL_GRANT_MULTICLASS"/>

same as Cleric and Wizard

</description>
<sheet display="false" />
<rules>
<select type="Feat" name="Fighting Style (Fighter 1)" supports="Fighting Style" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<select type="Feat" name="Fighting Style (Fighter 1)" supports="Fighting Style" />
<grant type="Grants" id="ID_INTERNAL_GRANTS_FIGHTING_STYLE_FEATURE" />
<select type="Feat" name="Fighting Style (Fighter 1)" supports="Fighting Style" />

Same as the spellcasting grant, this is needed for the way Fighting Style feats are coded.

Copy link
Contributor

@FreshRoyal FreshRoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another one in which I don't see anything that wasn't already noticed. Just needs suggestions merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants