Skip to content

Conversation

@Tel0k
Copy link

@Tel0k Tel0k commented Sep 16, 2024

No description provided.

added !ID_INTERNAL_GRANTS_BACKGROUND_ASI requirement to prevent doubled asi selection when using 2024 backgrounds
@FreshRoyal
Copy link
Contributor

I haven't look at all the way through these yet, but the background ASI grant comes from the background so that it can replace the racial ASIs. With how the backgrounds are implemented now, the background ASIs are removed when the grant is given.

@Tel0k
Copy link
Author

Tel0k commented Sep 16, 2024

No, the background ASIs are not removed when the grant is given, it's the contrary. When the grant is given, each background uses its own +2,+1/+1,+1,+1 ASIs (that is restricted to only 3 predetermined abilities) appended at the end of each file. When the grant is not given (using any backgrounds other than phb2024 ones) it uses the racial ASIs..

@FreshRoyal
Copy link
Contributor

Ah, alright, my mistake

@kgirtxd kgirtxd linked an issue Oct 30, 2024 that may be closed by this pull request
@tregolani
Copy link

Do we want to add setters for the short description in Aurora? Currently they're just blanks, which looks a bit strange when compared to backgrounds from other sources.
image

Copy link

@tregolani tregolani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a few corrections needed during my app testing. Two instances of PHB14 proficiency grants, a few typos, and a couple incorrect skill prof grants.

@Tel0k Tel0k changed the title [PHB24] Backgrounds [PHB24] Backgrounds and Feats Nov 24, 2024
Copy link
Contributor

@NickVendel NickVendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review got quite long, so here's part 1 for now.

Comment on lines 1689 to 1693
<grant type="Grants" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_INTELLIGENCE" />
</rules>
</element>
<element name="Intelligence Saving Throw Proficiency" type="Grants" source="Internal" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_INTELLIGENCE">
<rules>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<grant type="Grants" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_INTELLIGENCE" />
</rules>
</element>
<element name="Intelligence Saving Throw Proficiency" type="Grants" source="Internal" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_INTELLIGENCE">
<rules>

Comment on lines 1697 to 1702
<element name="Resilient (Wisdom)" type="Feat Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_FEAT_RESILIENT_WISDOM">
<requirements>!ID_WOTC_PHB24_PROFICIENCY_SAVINGTHROW_WISDOM</requirements>
<compendium display="false" />
<supports>Resilient</supports>
<description>
<p>You gain proficiency with Wisdom saving throws.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<element name="Resilient (Wisdom)" type="Feat Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_FEAT_RESILIENT_WISDOM">
<requirements>!ID_WOTC_PHB24_PROFICIENCY_SAVINGTHROW_WISDOM</requirements>
<compendium display="false" />
<supports>Resilient</supports>
<description>
<p>You gain proficiency with Wisdom saving throws.</p>
<element name="Wisdom" type="Feat Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_FEAT_RESILIENT_WISDOM">
<requirements>!ID_WOTC_PHB24_PROFICIENCY_SAVINGTHROW_WISDOM</requirements>
<compendium display="false" />
<supports>PHB24 Resilient</supports>
<description>
<p>You gain proficiency with Wisdom saving throws, and increase your Wisdom by 1, to a maximum of 20.</p>

Comment on lines 1707 to 1711
<grant type="Grants" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_WISDOM" />
</rules>
</element>
<element name="Wisdom Saving Throw Proficiency" type="Grants" source="Internal" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_WISDOM">
<rules>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<grant type="Grants" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_WISDOM" />
</rules>
</element>
<element name="Wisdom Saving Throw Proficiency" type="Grants" source="Internal" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_WISDOM">
<rules>

Comment on lines 1715 to 1720
<element name="Resilient (Charisma)" type="Feat Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_FEAT_RESILIENT_CHARISMA">
<requirements>!ID_WOTC_PHB24_PROFICIENCY_SAVINGTHROW_CHARISMA</requirements>
<compendium display="false" />
<supports>Resilient</supports>
<description>
<p>You gain proficiency with Charisma saving throws.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<element name="Resilient (Charisma)" type="Feat Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_FEAT_RESILIENT_CHARISMA">
<requirements>!ID_WOTC_PHB24_PROFICIENCY_SAVINGTHROW_CHARISMA</requirements>
<compendium display="false" />
<supports>Resilient</supports>
<description>
<p>You gain proficiency with Charisma saving throws.</p>
<element name="Charisma" type="Feat Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_FEAT_RESILIENT_CHARISMA">
<requirements>!ID_WOTC_PHB24_PROFICIENCY_SAVINGTHROW_CHARISMA</requirements>
<compendium display="false" />
<supports>PHB24 Resilient</supports>
<description>
<p>You gain proficiency with Charisma saving throws, and increase your Charisma by 1, to a maximum of 20.</p>

Comment on lines 1725 to 1729
<grant type="Grants" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_CHARISMA" />
</rules>
</element>
<element name="Charisma Saving Throw Proficiency" type="Grants" source="Internal" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_CHARISMA">
<rules>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<grant type="Grants" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_CHARISMA" />
</rules>
</element>
<element name="Charisma Saving Throw Proficiency" type="Grants" source="Internal" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_CHARISMA">
<rules>

Copy link
Contributor

@NickVendel NickVendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review got quite long, so here's part 1 for now.

Tel0k and others added 6 commits October 2, 2025 11:25
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Copy link
Contributor

@NickVendel NickVendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part 2

Comment on lines 1049 to 1051
<prerequisite>Level 4+, Intelligence, Wisdom, or Charisma 13+, General Feat</prerequisite>
<description>
<p><em>General Feat (Prerequisite: Level 4+; Intelligence, Wisdom, or Charisma 13+)</em></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<prerequisite>Level 4+, Intelligence, Wisdom, or Charisma 13+, General Feat</prerequisite>
<description>
<p><em>General Feat (Prerequisite: Level 4+; Intelligence, Wisdom, or Charisma 13+)</em></p>
<prerequisite>Level 4+, Intelligence, Wisdom, or Charisma 13+</prerequisite>
<description>
<p class="flavor">General Feat (Prerequisite: Level 4+; Intelligence, Wisdom, or Charisma 13+)</p>

Comment on lines 1059 to 1064
<select type="Feat Feature" name="Ability Score Increase (Ritual Caster)" supports="Ritual Caster" />
<select type="Spell" name="1st-level Spell (Ritual Caster)" supports="Ritual,1" number="2" />
<select type="Spell" name="1st-level Spell (Ritual Caster)" supports="Ritual,1" level="5" />
<select type="Spell" name="1st-level Spell (Ritual Caster)" supports="Ritual,1" level="9" />
<select type="Spell" name="1st-level Spell (Ritual Caster)" supports="Ritual,1" level="13" />
<select type="Spell" name="1st-level Spell (Ritual Caster)" supports="Ritual,1" level="17" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<select type="Feat Feature" name="Ability Score Increase (Ritual Caster)" supports="Ritual Caster" />
<select type="Spell" name="1st-level Spell (Ritual Caster)" supports="Ritual,1" number="2" />
<select type="Spell" name="1st-level Spell (Ritual Caster)" supports="Ritual,1" level="5" />
<select type="Spell" name="1st-level Spell (Ritual Caster)" supports="Ritual,1" level="9" />
<select type="Spell" name="1st-level Spell (Ritual Caster)" supports="Ritual,1" level="13" />
<select type="Spell" name="1st-level Spell (Ritual Caster)" supports="Ritual,1" level="17" />
<select type="Feat Feature" name="Ability Score Increase (Ritual Caster)" supports="PHB24 Ritual Caster" />
<select type="Spell" name="1st Ritual Spell (Ritual Caster)" supports="Ritual,1" requirements="[proficiency:1]" />
<select type="Spell" name="2nd Ritual Spell (Ritual Caster)" supports="Ritual,1" requirements="[proficiency:2]" />
<select type="Spell" name="3rd Ritual Spell (Ritual Caster)" supports="Ritual,1" requirements="[proficiency:3]" />
<select type="Spell" name="4th Ritual Spell (Ritual Caster)" supports="Ritual,1" requirements="[proficiency:4]" />
<select type="Spell" name="5th Ritual Spell (Ritual Caster)" supports="Ritual,1" requirements="[proficiency:5]" />
<select type="Spell" name="6th Ritual Spell (Ritual Caster)" supports="Ritual,1" requirements="[proficiency:6]" />
<select type="Spell" name="7th Ritual Spell (Ritual Caster)" supports="Ritual,1" requirements="[proficiency:7]" />
<select type="Spell" name="8th Ritual Spell (Ritual Caster)" supports="Ritual,1" requirements="[proficiency:8]" />

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nick, why the last 2 selections? PB can't go above 6, aren't those unnecessary?

Comment on lines 1069 to 1075
<supports>Ritual Caster</supports>
<description>
<p>Increase your Intelligence by 1, to a maximum of 20.</p>
</description>
<sheet alt="Ritual Caster">
<description>Choose {{proficiency}} level 1 spells that have the Ritual tag. You always have those spells prepared, and you can cast them with any spell slots you have. The spells' spellcasting ability is Intelligence.
You can cast a Ritual spell that you have prepared using its regular casting time rather than the extended time for a Ritual. Doing so doesn't require a spell slot. Once you cast the spell in this way, you can't use this benefit again until you finish a Long Rest.</description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<supports>Ritual Caster</supports>
<description>
<p>Increase your Intelligence by 1, to a maximum of 20.</p>
</description>
<sheet alt="Ritual Caster">
<description>Choose {{proficiency}} level 1 spells that have the Ritual tag. You always have those spells prepared, and you can cast them with any spell slots you have. The spells' spellcasting ability is Intelligence.
You can cast a Ritual spell that you have prepared using its regular casting time rather than the extended time for a Ritual. Doing so doesn't require a spell slot. Once you cast the spell in this way, you can't use this benefit again until you finish a Long Rest.</description>
<supports>PHB24 Ritual Caster</supports>
<description>
<p>Increase your Intelligence by 1, to a maximum of 20.</p>
</description>
<sheet alt="Ritual Caster" usage="1/Long Rest">
<description>You can cast a Ritual spell that you have prepared using its regular casting time rather than the extended time for a Ritual without expending a spell slot. &#13;
Intelligence is your spellcasting ability for this feat's spells.</description>

Comment on lines 1083 to 1089
<supports>Ritual Caster</supports>
<description>
<p>Increase your Wisdom by 1, to a maximum of 20.</p>
</description>
<sheet alt="Ritual Caster">
<description>Choose {{proficiency}} level 1 spells that have the Ritual tag. You always have those spells prepared, and you can cast them with any spell slots you have. The spells' spellcasting ability is Intelligence.
You can cast a Ritual spell that you have prepared using its regular casting time rather than the extended time for a Ritual. Doing so doesn't require a spell slot. Once you cast the spell in this way, you can't use this benefit again until you finish a Long Rest.</description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<supports>Ritual Caster</supports>
<description>
<p>Increase your Wisdom by 1, to a maximum of 20.</p>
</description>
<sheet alt="Ritual Caster">
<description>Choose {{proficiency}} level 1 spells that have the Ritual tag. You always have those spells prepared, and you can cast them with any spell slots you have. The spells' spellcasting ability is Intelligence.
You can cast a Ritual spell that you have prepared using its regular casting time rather than the extended time for a Ritual. Doing so doesn't require a spell slot. Once you cast the spell in this way, you can't use this benefit again until you finish a Long Rest.</description>
<supports>PHB24 Ritual Caster</supports>
<description>
<p>Increase your Wisdom by 1, to a maximum of 20.</p>
</description>
<sheet alt="Ritual Caster" usage="1/Long Rest">
<description>You can cast a Ritual spell that you have prepared using its regular casting time rather than the extended time for a Ritual without expending a spell slot. &#13;
Wisdom is your spellcasting ability for this feat's spells.</description>

Comment on lines 1097 to 1103
<supports>Ritual Caster</supports>
<description>
<p>Increase your Charisma by 1, to a maximum of 20.</p>
</description>
<sheet alt="Ritual Caster">
<description>Choose {{proficiency}} level 1 spells that have the Ritual tag. You always have those spells prepared, and you can cast them with any spell slots you have. The spells' spellcasting ability is Intelligence.
You can cast a Ritual spell that you have prepared using its regular casting time rather than the extended time for a Ritual. Doing so doesn't require a spell slot. Once you cast the spell in this way, you can't use this benefit again until you finish a Long Rest.</description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<supports>Ritual Caster</supports>
<description>
<p>Increase your Charisma by 1, to a maximum of 20.</p>
</description>
<sheet alt="Ritual Caster">
<description>Choose {{proficiency}} level 1 spells that have the Ritual tag. You always have those spells prepared, and you can cast them with any spell slots you have. The spells' spellcasting ability is Intelligence.
You can cast a Ritual spell that you have prepared using its regular casting time rather than the extended time for a Ritual. Doing so doesn't require a spell slot. Once you cast the spell in this way, you can't use this benefit again until you finish a Long Rest.</description>
<supports>PHB24 Ritual Caster</supports>
<description>
<p>Increase your Charisma by 1, to a maximum of 20.</p>
</description>
<sheet alt="Ritual Caster" usage="1/Long Rest">
<description>You can cast a Ritual spell that you have prepared using its regular casting time rather than the extended time for a Ritual without expending a spell slot. &#13;
Charisma is your spellcasting ability for this feat's spells.</description>

Comment on lines 290 to 293
<supports>Boon, 19</supports>
<prerequisite>Level 19+, Epic Boon Feat</prerequisite>
<description>
<p><em>Epic Boon Feat (Prerequisite: Level 19+)</em></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<supports>Boon, 19</supports>
<prerequisite>Level 19+, Epic Boon Feat</prerequisite>
<description>
<p><em>Epic Boon Feat (Prerequisite: Level 19+)</em></p>
<supports>Epic Boon</supports>
<prerequisite>Level 19+</prerequisite>
<description>
<p class="flavor">Epic Boon Feat (Prerequisite: Level 19+)</p>

Comment on lines 299 to 300
<sheet>
<description>While within Dim Light or Darkness, you have Resistance to all damage except Psychic and Radiant, and as a Bonus Action, you can give yourself the invisible condition. The condition ends on you immediately after you take an action, a Bonus Action, or a Reaction.</description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<sheet>
<description>While within Dim Light or Darkness, you have Resistance to all damage except Psychic and Radiant, and as a Bonus Action, you can give yourself the invisible condition. The condition ends on you immediately after you take an action, a Bonus Action, or a Reaction.</description>
<sheet action="Bonus Action">
<description>While within Dim Light or Darkness, you can become Invisible. The condition ends on you immediately after you take an action, a Bonus Action, or a Reaction. &#13;
Additionally, while within Dim Light or Darkness, you have Resistance to all damage except Psychic and Radiant.</description>

<rules>
<select type="Ability Score Improvement" name="Ability Score Increase (Boon of the Night Spirit)" supports="Boon Ability Score Increase" />
</rules>
</element>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</element>
</element>

Comment on lines 308 to 311
<supports>Boon, 19</supports>
<prerequisite>Level 19+, Epic Boon Feat</prerequisite>
<description>
<p><em>Epic Boon Feat (Prerequisite: Level 19+)</em></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<supports>Boon, 19</supports>
<prerequisite>Level 19+, Epic Boon Feat</prerequisite>
<description>
<p><em>Epic Boon Feat (Prerequisite: Level 19+)</em></p>
<supports>Epic Boon</supports>
<prerequisite>Level 19+</prerequisite>
<description>
<p class="flavor">Epic Boon Feat (Prerequisite: Level 19+)</p>

Comment on lines 316 to 318
<sheet>
<description>You have Truesight with a range of 60ft.</description>
</sheet>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<sheet>
<description>You have Truesight with a range of 60ft.</description>
</sheet>
<sheet display="false" />

Copy link
Contributor

@NickVendel NickVendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part 2

Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backgrounds

4 participants