-
Notifications
You must be signed in to change notification settings - Fork 100
[PHB24] Backgrounds and Feats #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: phb2024
Are you sure you want to change the base?
Conversation
added !ID_INTERNAL_GRANTS_BACKGROUND_ASI requirement to prevent doubled asi selection when using 2024 backgrounds
|
I haven't look at all the way through these yet, but the background ASI grant comes from the background so that it can replace the racial ASIs. With how the backgrounds are implemented now, the background ASIs are removed when the grant is given. |
|
No, the background ASIs are not removed when the grant is given, it's the contrary. When the grant is given, each background uses its own +2,+1/+1,+1,+1 ASIs (that is restricted to only 3 predetermined abilities) appended at the end of each file. When the grant is not given (using any backgrounds other than phb2024 ones) it uses the racial ASIs.. |
|
Ah, alright, my mistake |
tregolani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a few corrections needed during my app testing. Two instances of PHB14 proficiency grants, a few typos, and a couple incorrect skill prof grants.
4a26cf5 to
1383977
Compare
NickVendel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review got quite long, so here's part 1 for now.
| <grant type="Grants" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_INTELLIGENCE" /> | ||
| </rules> | ||
| </element> | ||
| <element name="Intelligence Saving Throw Proficiency" type="Grants" source="Internal" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_INTELLIGENCE"> | ||
| <rules> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <grant type="Grants" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_INTELLIGENCE" /> | |
| </rules> | |
| </element> | |
| <element name="Intelligence Saving Throw Proficiency" type="Grants" source="Internal" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_INTELLIGENCE"> | |
| <rules> |
| <element name="Resilient (Wisdom)" type="Feat Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_FEAT_RESILIENT_WISDOM"> | ||
| <requirements>!ID_WOTC_PHB24_PROFICIENCY_SAVINGTHROW_WISDOM</requirements> | ||
| <compendium display="false" /> | ||
| <supports>Resilient</supports> | ||
| <description> | ||
| <p>You gain proficiency with Wisdom saving throws.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <element name="Resilient (Wisdom)" type="Feat Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_FEAT_RESILIENT_WISDOM"> | |
| <requirements>!ID_WOTC_PHB24_PROFICIENCY_SAVINGTHROW_WISDOM</requirements> | |
| <compendium display="false" /> | |
| <supports>Resilient</supports> | |
| <description> | |
| <p>You gain proficiency with Wisdom saving throws.</p> | |
| <element name="Wisdom" type="Feat Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_FEAT_RESILIENT_WISDOM"> | |
| <requirements>!ID_WOTC_PHB24_PROFICIENCY_SAVINGTHROW_WISDOM</requirements> | |
| <compendium display="false" /> | |
| <supports>PHB24 Resilient</supports> | |
| <description> | |
| <p>You gain proficiency with Wisdom saving throws, and increase your Wisdom by 1, to a maximum of 20.</p> |
| <grant type="Grants" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_WISDOM" /> | ||
| </rules> | ||
| </element> | ||
| <element name="Wisdom Saving Throw Proficiency" type="Grants" source="Internal" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_WISDOM"> | ||
| <rules> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <grant type="Grants" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_WISDOM" /> | |
| </rules> | |
| </element> | |
| <element name="Wisdom Saving Throw Proficiency" type="Grants" source="Internal" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_WISDOM"> | |
| <rules> |
| <element name="Resilient (Charisma)" type="Feat Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_FEAT_RESILIENT_CHARISMA"> | ||
| <requirements>!ID_WOTC_PHB24_PROFICIENCY_SAVINGTHROW_CHARISMA</requirements> | ||
| <compendium display="false" /> | ||
| <supports>Resilient</supports> | ||
| <description> | ||
| <p>You gain proficiency with Charisma saving throws.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <element name="Resilient (Charisma)" type="Feat Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_FEAT_RESILIENT_CHARISMA"> | |
| <requirements>!ID_WOTC_PHB24_PROFICIENCY_SAVINGTHROW_CHARISMA</requirements> | |
| <compendium display="false" /> | |
| <supports>Resilient</supports> | |
| <description> | |
| <p>You gain proficiency with Charisma saving throws.</p> | |
| <element name="Charisma" type="Feat Feature" source="Player’s Handbook 2024" id="ID_WOTC_PHB24_FEAT_RESILIENT_CHARISMA"> | |
| <requirements>!ID_WOTC_PHB24_PROFICIENCY_SAVINGTHROW_CHARISMA</requirements> | |
| <compendium display="false" /> | |
| <supports>PHB24 Resilient</supports> | |
| <description> | |
| <p>You gain proficiency with Charisma saving throws, and increase your Charisma by 1, to a maximum of 20.</p> |
| <grant type="Grants" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_CHARISMA" /> | ||
| </rules> | ||
| </element> | ||
| <element name="Charisma Saving Throw Proficiency" type="Grants" source="Internal" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_CHARISMA"> | ||
| <rules> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <grant type="Grants" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_CHARISMA" /> | |
| </rules> | |
| </element> | |
| <element name="Charisma Saving Throw Proficiency" type="Grants" source="Internal" id="ID_INTERNAL_GRANTS_PHB24_PROFICIENCY_SAVINGTHROW_CHARISMA"> | |
| <rules> |
NickVendel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review got quite long, so here's part 1 for now.
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
NickVendel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part 2
| <prerequisite>Level 4+, Intelligence, Wisdom, or Charisma 13+, General Feat</prerequisite> | ||
| <description> | ||
| <p><em>General Feat (Prerequisite: Level 4+; Intelligence, Wisdom, or Charisma 13+)</em></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <prerequisite>Level 4+, Intelligence, Wisdom, or Charisma 13+, General Feat</prerequisite> | |
| <description> | |
| <p><em>General Feat (Prerequisite: Level 4+; Intelligence, Wisdom, or Charisma 13+)</em></p> | |
| <prerequisite>Level 4+, Intelligence, Wisdom, or Charisma 13+</prerequisite> | |
| <description> | |
| <p class="flavor">General Feat (Prerequisite: Level 4+; Intelligence, Wisdom, or Charisma 13+)</p> |
| <select type="Feat Feature" name="Ability Score Increase (Ritual Caster)" supports="Ritual Caster" /> | ||
| <select type="Spell" name="1st-level Spell (Ritual Caster)" supports="Ritual,1" number="2" /> | ||
| <select type="Spell" name="1st-level Spell (Ritual Caster)" supports="Ritual,1" level="5" /> | ||
| <select type="Spell" name="1st-level Spell (Ritual Caster)" supports="Ritual,1" level="9" /> | ||
| <select type="Spell" name="1st-level Spell (Ritual Caster)" supports="Ritual,1" level="13" /> | ||
| <select type="Spell" name="1st-level Spell (Ritual Caster)" supports="Ritual,1" level="17" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <select type="Feat Feature" name="Ability Score Increase (Ritual Caster)" supports="Ritual Caster" /> | |
| <select type="Spell" name="1st-level Spell (Ritual Caster)" supports="Ritual,1" number="2" /> | |
| <select type="Spell" name="1st-level Spell (Ritual Caster)" supports="Ritual,1" level="5" /> | |
| <select type="Spell" name="1st-level Spell (Ritual Caster)" supports="Ritual,1" level="9" /> | |
| <select type="Spell" name="1st-level Spell (Ritual Caster)" supports="Ritual,1" level="13" /> | |
| <select type="Spell" name="1st-level Spell (Ritual Caster)" supports="Ritual,1" level="17" /> | |
| <select type="Feat Feature" name="Ability Score Increase (Ritual Caster)" supports="PHB24 Ritual Caster" /> | |
| <select type="Spell" name="1st Ritual Spell (Ritual Caster)" supports="Ritual,1" requirements="[proficiency:1]" /> | |
| <select type="Spell" name="2nd Ritual Spell (Ritual Caster)" supports="Ritual,1" requirements="[proficiency:2]" /> | |
| <select type="Spell" name="3rd Ritual Spell (Ritual Caster)" supports="Ritual,1" requirements="[proficiency:3]" /> | |
| <select type="Spell" name="4th Ritual Spell (Ritual Caster)" supports="Ritual,1" requirements="[proficiency:4]" /> | |
| <select type="Spell" name="5th Ritual Spell (Ritual Caster)" supports="Ritual,1" requirements="[proficiency:5]" /> | |
| <select type="Spell" name="6th Ritual Spell (Ritual Caster)" supports="Ritual,1" requirements="[proficiency:6]" /> | |
| <select type="Spell" name="7th Ritual Spell (Ritual Caster)" supports="Ritual,1" requirements="[proficiency:7]" /> | |
| <select type="Spell" name="8th Ritual Spell (Ritual Caster)" supports="Ritual,1" requirements="[proficiency:8]" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nick, why the last 2 selections? PB can't go above 6, aren't those unnecessary?
| <supports>Ritual Caster</supports> | ||
| <description> | ||
| <p>Increase your Intelligence by 1, to a maximum of 20.</p> | ||
| </description> | ||
| <sheet alt="Ritual Caster"> | ||
| <description>Choose {{proficiency}} level 1 spells that have the Ritual tag. You always have those spells prepared, and you can cast them with any spell slots you have. The spells' spellcasting ability is Intelligence. | ||
| You can cast a Ritual spell that you have prepared using its regular casting time rather than the extended time for a Ritual. Doing so doesn't require a spell slot. Once you cast the spell in this way, you can't use this benefit again until you finish a Long Rest.</description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <supports>Ritual Caster</supports> | |
| <description> | |
| <p>Increase your Intelligence by 1, to a maximum of 20.</p> | |
| </description> | |
| <sheet alt="Ritual Caster"> | |
| <description>Choose {{proficiency}} level 1 spells that have the Ritual tag. You always have those spells prepared, and you can cast them with any spell slots you have. The spells' spellcasting ability is Intelligence. | |
| You can cast a Ritual spell that you have prepared using its regular casting time rather than the extended time for a Ritual. Doing so doesn't require a spell slot. Once you cast the spell in this way, you can't use this benefit again until you finish a Long Rest.</description> | |
| <supports>PHB24 Ritual Caster</supports> | |
| <description> | |
| <p>Increase your Intelligence by 1, to a maximum of 20.</p> | |
| </description> | |
| <sheet alt="Ritual Caster" usage="1/Long Rest"> | |
| <description>You can cast a Ritual spell that you have prepared using its regular casting time rather than the extended time for a Ritual without expending a spell slot. | |
| Intelligence is your spellcasting ability for this feat's spells.</description> |
| <supports>Ritual Caster</supports> | ||
| <description> | ||
| <p>Increase your Wisdom by 1, to a maximum of 20.</p> | ||
| </description> | ||
| <sheet alt="Ritual Caster"> | ||
| <description>Choose {{proficiency}} level 1 spells that have the Ritual tag. You always have those spells prepared, and you can cast them with any spell slots you have. The spells' spellcasting ability is Intelligence. | ||
| You can cast a Ritual spell that you have prepared using its regular casting time rather than the extended time for a Ritual. Doing so doesn't require a spell slot. Once you cast the spell in this way, you can't use this benefit again until you finish a Long Rest.</description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <supports>Ritual Caster</supports> | |
| <description> | |
| <p>Increase your Wisdom by 1, to a maximum of 20.</p> | |
| </description> | |
| <sheet alt="Ritual Caster"> | |
| <description>Choose {{proficiency}} level 1 spells that have the Ritual tag. You always have those spells prepared, and you can cast them with any spell slots you have. The spells' spellcasting ability is Intelligence. | |
| You can cast a Ritual spell that you have prepared using its regular casting time rather than the extended time for a Ritual. Doing so doesn't require a spell slot. Once you cast the spell in this way, you can't use this benefit again until you finish a Long Rest.</description> | |
| <supports>PHB24 Ritual Caster</supports> | |
| <description> | |
| <p>Increase your Wisdom by 1, to a maximum of 20.</p> | |
| </description> | |
| <sheet alt="Ritual Caster" usage="1/Long Rest"> | |
| <description>You can cast a Ritual spell that you have prepared using its regular casting time rather than the extended time for a Ritual without expending a spell slot. | |
| Wisdom is your spellcasting ability for this feat's spells.</description> |
| <supports>Ritual Caster</supports> | ||
| <description> | ||
| <p>Increase your Charisma by 1, to a maximum of 20.</p> | ||
| </description> | ||
| <sheet alt="Ritual Caster"> | ||
| <description>Choose {{proficiency}} level 1 spells that have the Ritual tag. You always have those spells prepared, and you can cast them with any spell slots you have. The spells' spellcasting ability is Intelligence. | ||
| You can cast a Ritual spell that you have prepared using its regular casting time rather than the extended time for a Ritual. Doing so doesn't require a spell slot. Once you cast the spell in this way, you can't use this benefit again until you finish a Long Rest.</description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <supports>Ritual Caster</supports> | |
| <description> | |
| <p>Increase your Charisma by 1, to a maximum of 20.</p> | |
| </description> | |
| <sheet alt="Ritual Caster"> | |
| <description>Choose {{proficiency}} level 1 spells that have the Ritual tag. You always have those spells prepared, and you can cast them with any spell slots you have. The spells' spellcasting ability is Intelligence. | |
| You can cast a Ritual spell that you have prepared using its regular casting time rather than the extended time for a Ritual. Doing so doesn't require a spell slot. Once you cast the spell in this way, you can't use this benefit again until you finish a Long Rest.</description> | |
| <supports>PHB24 Ritual Caster</supports> | |
| <description> | |
| <p>Increase your Charisma by 1, to a maximum of 20.</p> | |
| </description> | |
| <sheet alt="Ritual Caster" usage="1/Long Rest"> | |
| <description>You can cast a Ritual spell that you have prepared using its regular casting time rather than the extended time for a Ritual without expending a spell slot. | |
| Charisma is your spellcasting ability for this feat's spells.</description> |
| <supports>Boon, 19</supports> | ||
| <prerequisite>Level 19+, Epic Boon Feat</prerequisite> | ||
| <description> | ||
| <p><em>Epic Boon Feat (Prerequisite: Level 19+)</em></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <supports>Boon, 19</supports> | |
| <prerequisite>Level 19+, Epic Boon Feat</prerequisite> | |
| <description> | |
| <p><em>Epic Boon Feat (Prerequisite: Level 19+)</em></p> | |
| <supports>Epic Boon</supports> | |
| <prerequisite>Level 19+</prerequisite> | |
| <description> | |
| <p class="flavor">Epic Boon Feat (Prerequisite: Level 19+)</p> |
| <sheet> | ||
| <description>While within Dim Light or Darkness, you have Resistance to all damage except Psychic and Radiant, and as a Bonus Action, you can give yourself the invisible condition. The condition ends on you immediately after you take an action, a Bonus Action, or a Reaction.</description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <sheet> | |
| <description>While within Dim Light or Darkness, you have Resistance to all damage except Psychic and Radiant, and as a Bonus Action, you can give yourself the invisible condition. The condition ends on you immediately after you take an action, a Bonus Action, or a Reaction.</description> | |
| <sheet action="Bonus Action"> | |
| <description>While within Dim Light or Darkness, you can become Invisible. The condition ends on you immediately after you take an action, a Bonus Action, or a Reaction. | |
| Additionally, while within Dim Light or Darkness, you have Resistance to all damage except Psychic and Radiant.</description> |
| <rules> | ||
| <select type="Ability Score Improvement" name="Ability Score Increase (Boon of the Night Spirit)" supports="Boon Ability Score Increase" /> | ||
| </rules> | ||
| </element> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| </element> | |
| </element> | |
| <supports>Boon, 19</supports> | ||
| <prerequisite>Level 19+, Epic Boon Feat</prerequisite> | ||
| <description> | ||
| <p><em>Epic Boon Feat (Prerequisite: Level 19+)</em></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <supports>Boon, 19</supports> | |
| <prerequisite>Level 19+, Epic Boon Feat</prerequisite> | |
| <description> | |
| <p><em>Epic Boon Feat (Prerequisite: Level 19+)</em></p> | |
| <supports>Epic Boon</supports> | |
| <prerequisite>Level 19+</prerequisite> | |
| <description> | |
| <p class="flavor">Epic Boon Feat (Prerequisite: Level 19+)</p> |
| <sheet> | ||
| <description>You have Truesight with a range of 60ft.</description> | ||
| </sheet> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <sheet> | |
| <description>You have Truesight with a range of 60ft.</description> | |
| </sheet> | |
| <sheet display="false" /> |
NickVendel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part 2
Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>

No description provided.