Switch from "afplay" to "mpv" for cross-platform support#6
Open
0xf0xx0 wants to merge 2 commits intoAudiusProject:mainfrom
Open
Switch from "afplay" to "mpv" for cross-platform support#60xf0xx0 wants to merge 2 commits intoAudiusProject:mainfrom
0xf0xx0 wants to merge 2 commits intoAudiusProject:mainfrom
Conversation
|
What OS does this add support for? I'm not quite sure which OS uses the |
Author
|
This adds support for Linux and macOS, i dont know enough about the windows shell to know what it uses to play audio files. |
|
Fair enough. You might want to amend the documentation on installation per platform. |
Author
|
and done, this should be good |
cheran-senthil
approved these changes
Sep 14, 2022
Contributor
cheran-senthil
left a comment
cheran-senthil
left a comment
There was a problem hiding this comment.
Sorry, I haven't looked at this in a while, thanks for the work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5.