feat(rewards): log per-validator attestation failures with request_id#852
Merged
Conversation
When a validator fails to return a reward claim attestation, we silently marked it bad and moved on, leaving no way to see which validator failed or why. Add a warn-level log in fetchAttestations and in the coin redeem inline validator loop with the validator endpoint, owner, claim context (handle, rewardId, specifier), and underlying error. Also add an ApiServer.requestLogger(c) helper that binds the requestid-middleware request_id into a per-request child of app.logger, and use it in v1ClaimRewards and v1CoinsPostRedeem so handler logs can be correlated with access logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a validator fails to return a reward claim attestation, we silently marked it bad and moved on, leaving no way to see which validator failed or why. Add a warn-level log in fetchAttestations and in the coin redeem inline validator loop with the validator endpoint, owner, claim context (handle, rewardId, specifier), and underlying error.
Also add an ApiServer.requestLogger(c) helper that binds the requestid-middleware request_id into a per-request child of app.logger, and use it in v1ClaimRewards and v1CoinsPostRedeem so handler logs can be correlated with access logs.