audioreach-driver: Remove header dependencies and fix compilation warnings #17
Conversation
…nings Remove unnecessary header dependencies to improve build compatibility with Debian-based systems. Clean up the audioreach driver code to address compilation warnings including missing function prototypes and undefined symbols. These changes have been tested and verified on QCS6490-RB3gen2 and Lemans-EVK development boards. Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
| return qcs6490_snd_wcd_jack_setup(rtd, &data->jack, &data->jack_setup); | ||
| } | ||
|
|
||
| static int qcs6490_snd_startup(struct snd_pcm_substream *substream) |
There was a problem hiding this comment.
I am not getting the context of this change. How is it related to debian compilation? I thought we are just duplicating definitions from header files which are not residing in /inc
There was a problem hiding this comment.
in existing machine driver in upstream, the startup snd-ops function defined in sound/soc/qcom/sdw.c and not in machine driver, the function declarations done in sound/soc/qcom/sdw.c not in Include.
As part of independed machine driver compilation startup defined in machine driver since it's driver specific snd ops.
| ret = fifo_pop(&backup); | ||
| if (ret < 0) | ||
| AUDIO_PKT_ERR("Failed to pop backup ports from FIFO\n"); | ||
| dev_dbg(dev, "Failed to pop backup ports from FIFO\n"); |
There was a problem hiding this comment.
Is there AUDIO_PKT_DBG macro? Is AUDIO_PKT_ERR defined to allow log level change at run-time?
There was a problem hiding this comment.
AUDIO_PKT_DBG macro not available and there is no log level AUDIO_PKT_ERR.
|
Please help rebase the PR, Observing conflicts in audioreach-driver/q6apm_audio_pkt.c file |
|
sure will rebase the PR by resolving conflicts |
3 participants
Remove unnecessary header dependencies to improve build compatibility with Debian-based systems. Clean up the audioreach driver code to address compilation warnings including missing function prototypes and undefined symbols.
These changes have been tested and verified on QCS6490-RB3gen2 and Lemans-EVK development boards.