fix: use language-independent device identifiers for PnP device disabling#1559
Open
ArtanisInc wants to merge 1 commit intoAtlas-OS:mainfrom
Open
fix: use language-independent device identifiers for PnP device disabling#1559ArtanisInc wants to merge 1 commit intoAtlas-OS:mainfrom
ArtanisInc wants to merge 1 commit intoAtlas-OS:mainfrom
Conversation
…ling The previous implementation used exact FriendlyName matching which only worked on English Windows installations. This caused the PnP device disabling feature to fail silently on non-English systems. Changes: - Use InstanceId patterns (e.g., ACPI\PNP0103\*) which are universal and language-independent - Add wildcard support for FriendlyName matching (e.g., "AMD PSP*", "Intel*Management Engine*") - Process devices individually with foreach loops for better error handling - Add clarifying comments about the questionable nature of this tweak
|
Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Questions
Changes:
Describe your pull request
The PnP device disabling feature in
DISABLEPNP.ps1andScripts.psm1used exactFriendlyNamematching, which only worked on English Windows installations. This caused the feature to fail silently on non-English systems where device names are localized.Solution:
InstanceIdpatterns (e.g.,ACPI\PNP0103\*,ROOT\KDNIC\*) which are universal and language-independentFriendlyNamematching (e.g.,"AMD PSP*","Intel*Management Engine*")Why this matters:
The previous implementation would not disable any devices on non-English Windows installations (French, German, Spanish, etc.) because device names like "Composite Bus Enumerator" become "Énumérateur de bus composite" in French, "Composite-Busenumerator" in German, etc.
Using
InstanceIdpatterns ensures the tweak works consistently across all language installations, since ACPI/PCI identifiers are standardized.Note: VSCode did automatically format scripts.psm1 😅