Write HKCU\Keyboard Layout\Toggle and ...\Accessibility values as REG_SZ instead of REG_DWORD#1523
Merged
TheyCreeper merged 2 commits intoAtlas-OS:mainfrom Nov 16, 2025
Merged
Conversation
… REG_SZ instead of REG_DWORD The three values rewritten in `HKCU\Keyboard Layout\Toggle` should be of type REG_SZ: https://github.com/Atlas-OS/Atlas/blob/0b41102f1ee9696274a177db6aa913b8481377de/src/playbook/Executables/AtlasModules/Scripts/Modules/Qol/Qol.psm1#L47-L50 Expectation: <img width="1052" height="646" alt="Image" src="https://github.com/user-attachments/assets/7894fb5b-460f-46dd-b634-a5c23b4c432a" /> I also checked the `HKCU\Control Panel\Accessibility\...` `Flag` values rewritten in the same function in the registry in a stock install of Windows, and those were also of type REG_SZ, so have patched those too. I have not checked other values in other functions. We received reports of this causing crashes in Keyman; see keymanapp/keyman#14342. (We have now patched Keyman to work around the unexpected data type.)
Write `HKCU\Keyboard Layout\Toggle` and `...\Accessibility` values as REG_SZ instead of REG_DWORD
TheyCreeper
approved these changes
Nov 15, 2025
Member
RadNotRed
approved these changes
Nov 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Questions
Describe your pull request
The three values rewritten in
HKCU\Keyboard Layout\Toggleshould be of type REG_SZ.Expectation:
I also checked the
HKCU\Control Panel\Accessibility\...Flagvalues rewritten in the same function in the registry in a stock install of Windows, and those were also of type REG_SZ, so have patched those too. I have not checked other values in other functions.We received reports of this causing crashes in Keyman; see keymanapp/keyman#14342. (We have now patched Keyman to work around the unexpected data type.)