Skip to content

HighD dataset#37

Open
yair-schiff wants to merge 10 commits intoAtcold:masterfrom
yair-schiff:highD
Open

HighD dataset#37
yair-schiff wants to merge 10 commits intoAtcold:masterfrom
yair-schiff:highD

Conversation

@yair-schiff
Copy link
Copy Markdown
Collaborator

Enable code base to incorporate highD dataset into project pipeline

New scripts and files:

  • map_highD.py: Main script that creates environment and car classes for highD dataset
  • scripts/run_generate_data_highD.sh
  • scripts/submit_generate_data_highD.slurm

Modified files:

  • play_maps.py: Enable playback of highD map
  • extract_car_size.py and generate_trajectories.py: Enable data processing of highD
  • dataloader.py: Enable batch loading of highD

@yair-schiff yair-schiff requested a review from Atcold August 2, 2019 00:07
@Atcold
Copy link
Copy Markdown
Owner

Atcold commented Aug 6, 2019

My merging commit is weird... I had to edit manually stuff that was not supposed to be there. Maybe a GitHub bug?

Comment thread extract_car_size.py
'Right Alongside ID',
'Right Following ID',
'Lane Identification'
),
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, I think you could have used an ordered dict, and then you could have simply dumped the keys 😜

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Do you want me to change this, or should we leave it for now?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to change it, I can wait before merging.

Comment thread extract_car_size.py
for ts in time_slots:
d = df[ts]
car = lambda i: d[d['Vehicle ID'] == i]
def car(i): return d[d['Vehicle ID'] == i]
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PEP8's fault not mine...

Comment thread extract_car_size.py
print(c)

torch.save(car_sizes, 'traffic-data/state-action-cost/data_{}_v0/car_sizes.pth'.format(opt.map))
torch.save(car_sizes, f'traffic-data/state-action-cost/data_{opt.map}_v0/car_sizes.pth')
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Comment thread generate_trajectories.py
parser.add_argument('-map', type=str, default='i80', choices={'ai', 'i80', 'us101', 'lanker', 'peach'})
parser.add_argument('-map', type=str, default='i80', choices={'ai', 'i80', 'us101', 'lanker', 'peach', 'highD'})
parser.add_argument('-delta_t', type=float, default=0.1)
parser.add_argument('-recording', type=str, default="01",
Copy link
Copy Markdown
Owner

@Atcold Atcold Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use time_slot instead? They are used for the exact same purpose, no?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I think this is an artifact of me trying to keep this new script as similar to map_i80 as possible

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use time_slot for highd too.

Comment thread generate_trajectories.py

# HighD dataset will use recordings IDs rather than time slots
if opt.map == 'highD':
kwargs['rec'] = opt.recording
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this would be unnecessary.

#SBATCH --mail-type=FAIL # notifications for job fail
#SBATCH --mail-user=yzs208@nyu.edu

source activate PPUU
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not supposed to work... unless there's this before:

eval "$(conda shell.bash hook)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants