Skip to content

feat(contest): add cf16-final and dwango2016-prelims contest mappings#3652

Merged
KATO-Hiro merged 1 commit into
stagingfrom
#3634
Jun 13, 2026
Merged

feat(contest): add cf16-final and dwango2016-prelims contest mappings#3652
KATO-Hiro merged 1 commit into
stagingfrom
#3634

Conversation

@KATO-Hiro

@KATO-Hiro KATO-Hiro commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

close #3634

Summary by CodeRabbit

  • バグ修正
    • 追加のコンテストに対応し、コンテスト種別の分類とラベル表示を拡張しました。

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 17ee8474-7f7b-4abc-8695-e02ce5de29af

📥 Commits

Reviewing files that changed from the base of the PR and between 7915be4 and f9bb25e.

📒 Files selected for processing (3)
  • src/lib/utils/contest.ts
  • src/test/lib/utils/test_cases/contest_name_labels.ts
  • src/test/lib/utils/test_cases/contest_type.ts

📝 Walkthrough

Walkthrough

コンテスト種別分類用の定義に AGC_LIKE カテゴリ向けに cf16-final、ATCODER_OTHERS カテゴリ向けに dwango2016-prelims を追加し、対応するテストケースで種別分類とラベル生成の動作を検証。

Changes

コンテスト種別・ラベル生成の定義拡張

Layer / File(s) Summary
コンテスト種別定義の追加
src/lib/utils/contest.ts
AGC_LIKE に cf16-final 用の表示名定義を追加し、AGC_LIKE 判定・ラベル生成で対応。ATCODER_OTHERS に dwango2016-prelims 用の表示名定義を追加し、OTHERS 判定および getContestNameLabel でキー参照対象を拡張。
コンテスト種別・ラベルテストの拡張
src/test/lib/utils/test_cases/contest_type.ts, src/test/lib/utils/test_cases/contest_name_labels.ts
cf16-finalContestType.AGC_LIKE として分類する期待値テストを追加、dwango2016-prelimsContestType.OTHERS として分類するテストを追加、同コンテストのラベル期待値テスト(「第2回 ドワンゴからの挑戦状 予選」)を追加。

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • AtCoder-NoviSteps/AtCoderNoviSteps#1299: 両PRとも src/lib/utils/contest.tsclassifyContest ロジックを拡張し、OTHERS カテゴリの contestId プレフィックス判定を増やして対応するテストケースを追加しています。
  • AtCoder-NoviSteps/AtCoderNoviSteps#2146: 両PRとも src/lib/utils/contest.ts のコンテストプレフィックスマッピングと対応する contest_type テストケースを拡張し、コンテスト分類・ラベル生成の対象を広げています。
  • AtCoder-NoviSteps/AtCoderNoviSteps#1465: 両PRとも src/lib/utils/contest.ts のコンテストプレフィックスマッピング(main は dwango2016-prelims を追加、参照PR は mujin-pc-2018 を追加)を拡張し、対応するテストカバレッジを増やしています。

Poem

🎭 二つのコンテスト、名は新たに
cf16-finaldwango2016 仲間入り
分類テスト、ラベル確認も
シンプルな追加で完結す
🎯

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly and concisely summarizes the main change: adding contest mappings for cf16-final and dwango2016-prelims.
Linked Issues check ✅ Passed The code changes add the requested contest mappings for dwango2016-prelims and cf16-final with corresponding test cases, meeting the objectives from linked issue #3634.
Out of Scope Changes check ✅ Passed All changes are directly related to adding the requested contest mappings; no out-of-scope modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch #3634

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@KATO-Hiro KATO-Hiro left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KATO-Hiro KATO-Hiro merged commit dc4797a into staging Jun 13, 2026
3 checks passed
@KATO-Hiro KATO-Hiro deleted the #3634 branch June 13, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] 問題を追加しましょう

1 participant