Conversation
- Add 28 years (1998-2025) of ICPCPrelim seed data to prisma/tasks.ts - Implement AojIcpcPrelimProvider with per-year instantiation pattern - Add buildAojIcpcLetterMap util with override map for judge-gap years - Add titleFontSize optional field to ContestTableMetaData for per-provider font control - Register AojIcpcPrelimProvider in contest_table_provider_groups - Add plan.md under docs/dev-notes/2026-06-10/aoj-icpc-prelim-table/ Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ading Replace the single titleFontSize field with a ContestTableTitleStyle struct (headingTag, fontSize, fontWeight, bottomGap) to allow per-provider heading customisation. Add optional mainTitle to ContestTablesMetaData and render it as an h2 above the provider list in TaskTable; set it to 'ICPC 国内予選' for the ICPC Prelim group. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… and guide
Document lessons from the ICPC Prelim implementation: {@const} placement
restriction in Svelte templates, mutable module-level export testing pattern,
and the full Pattern 4 checklist covering year-range constants, generateTable/
getHeaderIdsForTask key alignment, override map testing, titleStyle, and
mainTitle.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… refactor Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughICPC国内予選（1998–2025）のコンテストテーブルを実装。年を受け取る AojIcpcPrelimProvider を複数生成し、ラベル上書き、動的見出しスタイル、グループ mainTitle 表示、関連データ・テスト・ドキュメントを追加。 ChangesICPC国内予選テーブル実装
実装ガイドとチェックリスト更新
🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/skills/add-contest-table-provider/instructions.md:
- Around line 32-34: The three long, overloaded sentences should be split into
clear, independent checklist items: one item describing the numeric-string
detection for task_table_index and that getHeaderIdsForTask must sort using
Number(a)-Number(b); a second item stating that display-only title transforms
(e.g. prepending a letter) must be implemented in generateTable and that
getHeaderIdsForTask must derive keys the same way to avoid missing cells; a
third item explaining the override map type (Record<string, Record<string,
string>>) per contest_id and the need to exercise that path in tests using
beforeEach/afterEach mutation. For each item, name the exact symbols to change
or test (getHeaderIdsForTask, generateTable, the override map) and keep each
line short and action-oriented so readers can implement the fixes without
ambiguity.
In `@src/features/tasks/types/contest-table/contest_table_provider.ts`:
- Around line 130-154: The JSDoc/example and provider usage reference a
nonstandard Tailwind class 'text-md' which may not exist; update the code and
docs so font sizes resolve reliably: either replace every occurrence of
'text-md' (e.g. in the ContestTableTitleStyle example/comment and in the
provider that sets fontSize: 'text-md') with a standard Tailwind class such as
'text-base' or 'text-lg', or add a matching entry under theme.extend.fontSize in
your Tailwind config to define 'md' -> desired size; ensure the
ContestTableTitleStyle documentation and the provider (where fontSize is set)
reflect the chosen standard or the newly added custom class so the renderer
applies the expected size.
In `@src/features/tasks/utils/contest-table/aoj_icpc_providers.ts`:
- Around line 51-62: The titleStyle.fontSize value in getMetadata() returns an
invalid Tailwind class 'text-md'; update the fontSize property in the
getMetadata() method (which returns ContestTableMetaData) from 'text-md' to a
valid Tailwind class such as 'text-base' (or 'text-lg' if larger text is
desired) so titleStyle.fontSize uses a supported class.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 9b41bc26-a8c9-4dcc-b165-92c04fb69de8
📒 Files selected for processing (14)
.claude/rules/svelte-components.md.claude/rules/testing.md.claude/skills/add-contest-table-provider/instructions.mddocs/guides/how-to-add-contest-table-provider.mdprisma/tasks.tssrc/features/tasks/components/contest-table/TaskTable.sveltesrc/features/tasks/types/contest-table/contest_table_provider.tssrc/features/tasks/utils/contest-table/aoj_icpc_labels.test.tssrc/features/tasks/utils/contest-table/aoj_icpc_labels.tssrc/features/tasks/utils/contest-table/aoj_icpc_providers.test.tssrc/features/tasks/utils/contest-table/aoj_icpc_providers.tssrc/features/tasks/utils/contest-table/contest_table_provider.tssrc/features/tasks/utils/contest-table/contest_table_provider_groups.test.tssrc/features/tasks/utils/contest-table/contest_table_provider_groups.ts
text-md is not a valid Tailwind v4 utility; text-base is the correct font-size class. Also simplifies the skill instructions for pattern 2/3. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #3633
Summary by CodeRabbit
新機能
ドキュメント
テスト