Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .claude/rules/prisma-db.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,12 @@ When a migration leaves `finished_at = NULL` in `_prisma_migrations`:

A `--rolled-back` migration is permanently skipped by `migrate deploy`; fixing the original file has no effect.

## Merged Data: Document Uniqueness Loss

Service functions that merge records from multiple sources (e.g., `getMergedTasksMap()` combining base tasks + `ContestTaskPair` entries) lose individual field uniqueness. Document that results contain duplicates in "unique" DB fields.

Example: `getMergedTasksMap()` returns multiple entries with same `task_id` but different `contest_id` — callers must not assume `task_id` is unique. UI layer must use composite keys (see svelte-components.md `{#each}` patterns).

## Validate Constraints

Prisma does not support `@@check`. To add one:
Expand Down
3 changes: 3 additions & 0 deletions .claude/rules/svelte-components.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ Use `$props()`, `$state()`, `$derived()`, `$effect()` in all components:
## `{#each}` Patterns

- Always key: `(item.id)` or `(i)`
- **Key MUST be unique per iteration** — if domain allows duplicates, use composite key (e.g. `contest_id + '-' + task_id`)
- Filter **before**, not inside with `{#if}`
- Use `{:else}` for empty lists

Expand All @@ -48,6 +49,8 @@ Use `$props()`, `$state()`, `$derived()`, `$effect()` in all components:
{/each}
```

**Common Trap:** `task_id` alone is NOT unique when same task appears in multiple contests. Use `contest_id + '-' + task_id` as composite key (see issue #3460 & PR #3442).

## Snippets vs Components

- **Snippet**: needs `$state` access, pure display, same-file; params require explicit type `{#snippet label(item: Item)}`
Expand Down
2 changes: 1 addition & 1 deletion src/lib/components/TaskList.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
</TableHead>

<TableBody class="divide-y divide-gray-200 dark:divide-gray-700">
{#each taskResults as taskResult (taskResult.task_id)}
{#each taskResults as taskResult (taskResult.contest_id + '-' + taskResult.task_id)}
<TableBodyRow
id={taskResult.contest_id + '-' + taskResult.task_id}
class={getBackgroundColorFrom(taskResult.status_name)}
Expand Down
Loading