Skip to content

chore: add vitest/globals and node types to tsconfig.json#3428

Merged
KATO-Hiro merged 2 commits into
stagingfrom
#3427
Apr 18, 2026
Merged

chore: add vitest/globals and node types to tsconfig.json#3428
KATO-Hiro merged 2 commits into
stagingfrom
#3427

Conversation

@KATO-Hiro

@KATO-Hiro KATO-Hiro commented Apr 18, 2026

Copy link
Copy Markdown
Collaborator

close #3427

Summary by CodeRabbit

リリースノート

  • Chores
    • 開発環境の型定義の構成を更新しました。これにより、開発ツールの互換性が向上します。

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@KATO-Hiro has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 51 minutes and 25 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 51 minutes and 25 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 13ceeff4-e303-4078-9e7e-13ed1b1e1649

📥 Commits

Reviewing files that changed from the base of the PR and between 0e37c39 and eef9a74.

📒 Files selected for processing (1)
  • tsconfig.json
📝 Walkthrough

Walkthrough

TypeScript設定ファイルにおいて、compilerOptions.typesオプションを明示的に追加し、nodevitest/globalsの型定義を有効化しました。他の設定変更はありません。

Changes

Cohort / File(s) Summary
TypeScript型定義の明示化
tsconfig.json
compilerOptions.types["node", "vitest/globals"] を追加し、型チェックエラーを解決

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

型の行き交う暗い森で
明示の光がともりけり
Node と Vitest、手を取り合い
エラーの霧は晴れゆかな ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PRタイトルは、tsconfig.jsonにvitest/globalsとnodeタイプを追加するという変更内容を明確かつ簡潔に要約しており、主要な変更を正確に反映しています。
Linked Issues check ✅ Passed リンクされた issue #3427 は型チェックのエラーを修正することを目的としており、本PR は tsconfig.json に型定義を追加してこれを達成しています。
Out of Scope Changes check ✅ Passed 本PR の変更は tsconfig.json への型定義追加のみであり、issue #3427 の目的である型チェックのエラー修正の範囲内です。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch #3427

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@tsconfig.json`:
- Line 16: The tsconfig's compilerOptions.types entry is replacing (not merging
with) the extended config's types, removing the Svelte types; update
compilerOptions.types to explicitly include the inherited Svelte entries plus
the added ones (e.g. ["svelte", "svelte/types/runtime", "node",
"vitest/globals"]) so Svelte type resolution is preserved, and adjust the inline
comment to correctly state that this list must enumerate the parent types
because "types" is replaced rather than merged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: ae60a602-8fd8-45a7-ba7a-ae6b745cae3c

📥 Commits

Reviewing files that changed from the base of the PR and between ac2b3fb and 0e37c39.

📒 Files selected for processing (1)
  • tsconfig.json

Comment thread tsconfig.json Outdated
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@KATO-Hiro KATO-Hiro left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KATO-Hiro KATO-Hiro merged commit 63d2e40 into staging Apr 18, 2026
3 checks passed
@KATO-Hiro KATO-Hiro deleted the #3427 branch April 18, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] 型チェックのエラーを修正しましょう

1 participant