Move and rename the include directory to sharedlib#548
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #548 +/- ##
==========================================
- Coverage 52.05% 51.73% -0.32%
==========================================
Files 17 17
Lines 2096 2101 +5
Branches 166 167 +1
==========================================
- Hits 1091 1087 -4
- Misses 933 942 +9
Partials 72 72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I've had a quick go at running this and it seems to work as you describe. The only point I have might be related to something I have raised before, so apologies if I'm repeating myself. It would be nice to not have to specify the Apart from that, all seems good to me. |
|
@AlfredMayhew I think this may be related to the way your shell is setup. Anyways it should now work as you suggest (although I haven't tested it fully). You still have to specify the flags for the other directories if you don't use the default values, though. If this is okay you can approve the PR, otherwise let's talk what other modifications are needed. |
AlfredMayhew
left a comment
There was a problem hiding this comment.
I think you're right about the tab completion being to do with my set-up. I'm running with Windows Subsystem for Linux, so it get's a bit weird sometimes.
I've given this a quick go and it seems to work as expected. Thanks!
This is the final step in reorganizing the
model/directory. The new structure is:configuration: the configuration directory, set by build script flag--configuration=. Includes the*.configand*.parametersfiles, pluscustomRateFuncs.f90. These files are editable by the user.constraints: the constraints directory (not changed)output: the output directory (not changed)sharedlib: the shared library directory, set by build script flag--shared_lib=. Includes the auto-generatedmechanism.*files and the pre-compiled mechanism shared library (mechanism.so). These files should not be editable by the user.mechanism.fac: the chemical mechanism file, set by build script flag--mechanism=, During build, this is converted in themechanism.*files and compiled together withcustomRateFuncs.f90into the mechanism shared library.Other changes:
--mcm=is repurposed to indicate the version of the MCM files--mcm=flag anymore--shared_libdoes not point to themechanism.sofile, but to the directory where the file is located (i.e.model/sharedlib@AlfredMayhew @bsn502, any comments?