Closed
Conversation
…out the new setting for fortran object files
rs028
reviewed
Jan 6, 2026
rs028
reviewed
Jan 7, 2026
Author
|
replaced with #545 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the code to work with sundials 7.5.0.
CVODEOBJDIRthe place where thee fortran object files are storedThis can be made neater with further code changes, I left the main right hand side function
FCVFUNunchanged, and invoked it from the new cvode method,Consolidating these methods would be a wise move.
The class of UserData could be neatened to store named variables, instead of old-style arrays of ints and reals