Skip to content

Unit tests for constraintFunctions.f90#339

Open
spco wants to merge 1 commit intoAtChem:masterfrom
spco:constraint_test
Open

Unit tests for constraintFunctions.f90#339
spco wants to merge 1 commit intoAtChem:masterfrom
spco:constraint_test

Conversation

@spco
Copy link
Collaborator

@spco spco commented Aug 24, 2018

Add unit test for calcPhotolysisRaw

@codecov
Copy link

codecov bot commented Aug 24, 2018

Codecov Report

Merging #339 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #339      +/-   ##
=========================================
+ Coverage   90.14%   90.2%   +0.05%     
=========================================
  Files          15      16       +1     
  Lines        2060    2072      +12     
=========================================
+ Hits         1857    1869      +12     
  Misses        203     203
Flag Coverage Δ
#build 65.1% <ø> (ø) ⬆️
#tests 89.67% <100%> (+0.06%) ⬆️
#unittests 35.61% <100%> (+0.61%) ⬆️
Impacted Files Coverage Δ
travis/unit_tests/constraint_test.f90 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b226a7...2f10024. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 5, 2018

Codecov Report

Merging #339 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
+ Coverage   90.32%   90.38%   +0.05%     
==========================================
  Files          15       16       +1     
  Lines        2088     2100      +12     
==========================================
+ Hits         1886     1898      +12     
  Misses        202      202
Flag Coverage Δ
#build 65.2% <ø> (ø) ⬆️
#tests 89.85% <100%> (+0.05%) ⬆️
#unittests 35.19% <100%> (+0.61%) ⬆️
Impacted Files Coverage Δ
travis/unit_tests/constraint_test.f90 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7170899...9ee88e7. Read the comment docs.

@rs028
Copy link
Collaborator

rs028 commented Oct 30, 2018

@spco do you want to merge this as well, or there is still work to do here?

@spco
Copy link
Collaborator Author

spco commented Oct 30, 2018

Yeah, this is a bit of a stub currently, and requires a fair bit more work, so I'd say leave it for later.

@rs028
Copy link
Collaborator

rs028 commented Oct 30, 2018

okay, no problem. We are good to go then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants