Skip to content

Use latest version of the dependencies #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hugobuddel wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use latest version of the dependencies #16

hugobuddel wants to merge 2 commits into from

Conversation

@hugobuddel
Copy link
Contributor

@hugobuddel hugobuddel commented May 24, 2024

This was referenced May 24, 2024
Merged
Merged
@hugobuddel
Copy link
Contributor Author

hugobuddel commented May 24, 2024

Apparently ScopeSim does not work with pytest 8, see AstarVienna/ScopeSim#421

This PR also does not do what it should do, as it still installs astropy 5 instead of astropy 6, see https://github.com/AstarVienna/ScopeSim_Data/actions/runs/9221355668/job/25370238518

I don't have more time to work on this now

@hugobuddel
Copy link
Contributor Author

hugobuddel commented May 24, 2024

Hopefully fixed the pytest 8 stuff in AstarVienna/ScopeSim#422 .

This is a good example why it is useful to test such things as early as we can. But maybe also a good example why it would be nicer to have a separate job for such tests.

@hugobuddel
Copy link
Contributor Author

hugobuddel commented May 24, 2024

I recall that moving to pytest 6 was also a headache. They seem to do there semver properly :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hugobuddel