Skip to content

Define slit transforms for image slicer IFUs and offset slits#922

Draft
oczoske wants to merge 11 commits into
mainfrom
oc/asymm_slit
Draft

Define slit transforms for image slicer IFUs and offset slits#922
oczoske wants to merge 11 commits into
mainfrom
oc/asymm_slit

Conversation

@oczoske
Copy link
Copy Markdown
Collaborator

@oczoske oczoske commented May 7, 2026

Description will follow.

Closes #919

@oczoske oczoske self-assigned this May 7, 2026
@oczoske oczoske added enhancement PR adding or improving a feature (use "Feature" type for issues (requests), not this label) effects Related to a ScopeSim effect spectroscopy Related to spectroscopic modes labels May 7, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 27.30924% with 181 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.27%. Comparing base (376ed01) to head (10a7bdb).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
scopesim/effects/micado_ifu_trace_list.py 24.39% 93 Missing ⚠️
scopesim/effects/metis_lms_trace_list.py 3.92% 49 Missing ⚠️
scopesim/effects/spectral_trace_list.py 45.31% 35 Missing ⚠️
scopesim/effects/apertures.py 40.00% 3 Missing ⚠️
scopesim/effects/spectral_trace_list_utils.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #922      +/-   ##
==========================================
- Coverage   75.19%   74.27%   -0.93%     
==========================================
  Files          70       71       +1     
  Lines        9018     9184     +166     
==========================================
+ Hits         6781     6821      +40     
- Misses       2237     2363     +126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oczoske oczoske moved this to 🏗 In progress in ScopeSim-development May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effects Related to a ScopeSim effect enhancement PR adding or improving a feature (use "Feature" type for issues (requests), not this label) spectroscopy Related to spectroscopic modes

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

Proper treatment of image slicers and offset slits for spectroscopy

1 participant