Add Kipp zonen shadow ring correction function#42
Open
AdamRJensen wants to merge 5 commits intomainfrom
Open
Conversation
Comment on lines
+22
to
+24
| slide_bar_setting = np.array([ | ||
| 132, 120, 108, 97, 85, 74, 63, 52, 42, 31, 21, 10, 0, 10, 21, 31, 42, 52, | ||
| 63, 74, 85, 97, 108, 120, 132]) |
Collaborator
There was a problem hiding this comment.
Are these values from the manual? The scale on the shadow rind goes up to 13 cm...
|
|
||
| df = pd.DataFrame( | ||
| data={ | ||
| 'Slide bar setting': slide_bar.round(1), |
Collaborator
There was a problem hiding this comment.
I suggest we convert these to cm and .round(0)
Comment on lines
+15
to
+16
| # scale that is oriented south must be read. In the northern hemisphere this is | ||
| # the lower part. |
Collaborator
There was a problem hiding this comment.
You can't really see the lower part of the scale, given where the shadow ring is installed... maybe the "smart" thing to do would be to convert the values to the "upper scale"?
Co-authored-by: Ioannis Sifnaios <88548539+IoannisSifnaios@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.