Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 34 additions & 23 deletions crates/muvm/src/guest/bridge/common.rs
Original file line number Diff line number Diff line change
Expand Up @@ -595,13 +595,13 @@ impl<'a, P: ProtocolHandler> Client<'a, P> {
identifier_sizes: [0; CROSS_DOMAIN_MAX_IDENTIFIERS],
data: [0u8; CROSS_DOMAIN_SR_TAIL_SIZE],
};
let head_len = self.request_head.len();
let recv_buf = if self.request_tail > 0 {
assert!(self.request_head.is_empty());
assert!(self.request_fds.is_empty());
let len = self.request_tail.min(ring_msg.data.len());
&mut ring_msg.data[..len]
} else {
let head_len = self.request_head.len();
ring_msg.data[..head_len].copy_from_slice(&self.request_head);
self.request_head.clear();
&mut ring_msg.data[head_len..]
Expand Down Expand Up @@ -629,35 +629,46 @@ impl<'a, P: ProtocolHandler> Client<'a, P> {
} else {
return Ok(true);
};
let buf = &mut ring_msg.data[..len];
let buf_len = head_len + len;
let buf = &mut ring_msg.data[..buf_len];

self.debug_loop.loop_local(buf);
let mut resources = Vec::new();
let mut finalizers = Vec::new();

let mut ptr = 0;
// Drain outstanding tail bytes first, then parse any remaining data.
if self.request_tail > 0 {
assert!(self.request_fds.is_empty());
self.request_tail -= buf.len();
} else {
let mut ptr = 0;
while ptr < buf.len() {
match P::process_send_stream(self, &mut buf[ptr..])? {
StreamSendResult::WantMore => break,
StreamSendResult::Processed {
resources: rs,
finalizers: fns,
consumed_bytes: msg_size,
} => {
ptr += msg_size;
resources.extend(rs);
finalizers.extend(fns);
},
}
}
if ptr < buf.len() {
self.request_head = buf[ptr..].to_vec();
} else {
self.request_tail = ptr - buf.len();

let consumed = self.request_tail.min(buf.len());
self.request_tail -= consumed;
ptr += consumed;
}

while ptr < buf.len() {
match P::process_send_stream(self, &mut buf[ptr..])? {
StreamSendResult::WantMore => break,
StreamSendResult::Processed {
resources: rs,
finalizers: fns,
consumed_bytes: msg_size,
} => {
ptr += msg_size;
resources.extend(rs);
finalizers.extend(fns);
},
}
}

if ptr > buf.len() {
// Track logical over-consumption
self.request_tail = ptr - buf.len();
} else if ptr < buf.len() {
// Preserve leftovers
self.request_head = buf[ptr..].to_vec();
}

if !self.request_head.is_empty() {
assert_eq!(self.request_tail, 0);
}
Expand Down
12 changes: 11 additions & 1 deletion crates/muvm/src/guest/bridge/x11.rs
Original file line number Diff line number Diff line change
Expand Up @@ -304,8 +304,18 @@ impl ProtocolHandler for X11ProtocolHandler {
req_len = u32::from_ne_bytes(buf[4..8].try_into().unwrap()) as usize * 4;
}
if buf[0] == X11_OPCODE_QUERY_EXTENSION {
if buf.len() < 8 {
return Ok(StreamSendResult::WantMore);
}

let namelen = u16::from_ne_bytes(buf[4..6].try_into().unwrap()) as usize;
let name = String::from_utf8_lossy(&buf[8..(8 + namelen)]);
let end = 8 + namelen;

if buf.len() < end {
return Ok(StreamSendResult::WantMore);
}

let name = String::from_utf8_lossy(&buf[8..end]);
if name == "DRI3" {
this.protocol_handler.dri3_qe_resp_seq = Some(this.protocol_handler.seq_no);
} else if name == "SYNC" {
Expand Down
Loading