Open
Conversation
Contributor
|
Heh, looks like you ran into some of the same missing instructions @AsahiLina ran into... can you rebase the HV stuff and see if any of your changes are still needed there? (FWIW for them to be correct you'd have had to expand the Python side too, but that's done now). |
Signed-off-by: R <rqou@berkeley.edu>
Signed-off-by: R <rqou@berkeley.edu>
Signed-off-by: R <rqou@berkeley.edu>
also add an alignment hack Signed-off-by: R <rqou@berkeley.edu>
Signed-off-by: R <rqou@berkeley.edu>
Signed-off-by: R <rqou@berkeley.edu>
Signed-off-by: R <rqou@berkeley.edu>
Signed-off-by: R <rqou@berkeley.edu>
Signed-off-by: R <rqou@berkeley.edu>
Contributor
Author
|
rebased, no HV changes seem to be required anymore |
marcan
reviewed
May 30, 2022
| if addr & 7: | ||
| raise AlignmentError() | ||
| self.write32(addr, data & 0xFFFFFFFF) | ||
| self.write32(addr + 4, data >> 32) |
Contributor
There was a problem hiding this comment.
What codepath is this used in? I'd prefer to keep the alignment fault '(at least by default) since this is usually a mistake when accessing registers, though I know Apple loves using unaligned 64-bit fields in some protocols. Can we make it a separate wrapper in ProxyUtils, a subclass, or something like that?
marcan
force-pushed
the
main
branch
3 times, most recently
from
06224ed to
88b1866
Compare
marcan
force-pushed
the
main
branch
2 times, most recently
from
f0edbd9 to
50c808d
Compare
marcan
force-pushed
the
main
branch
3 times, most recently
from
4f95305 to
95d67cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR this can successfully capture Bluetooth HCI commands being transported across the (seemingly) Apple-custom PCIe pipe interface
Known issues: