Skip to content

Potential fix for code scanning alert no. 21: Uncontrolled data used in path expression #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArshVermaGit merged 1 commit into from
May 21, 2026
Merged

Potential fix for code scanning alert no. 21: Uncontrolled data used in path expression #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion sentinelops-backend/app/services/local_git_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,13 @@
return ""
if not os.path.isdir(normalized):
return ""
if not os.path.isdir(os.path.join(normalized, ".git")):
git_dir = os.path.realpath(os.path.join(normalized, ".git"))
try:
if os.path.commonpath([git_dir, normalized]) != normalized:
return ""
except ValueError:
return ""
if not os.path.isdir(git_dir):

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression High

This path depends on a
user-provided value
Loading
.
return ""
return normalized

Expand Down
Loading