Skip to content

Polish Language#3

Closed
Olek980 wants to merge 52 commits intoArsenTech:mainfrom
Olek980:main
Closed

Polish Language#3
Olek980 wants to merge 52 commits intoArsenTech:mainfrom
Olek980:main

Conversation

@Olek980
Copy link
Copy Markdown
Contributor

@Olek980 Olek980 commented Mar 24, 2026

I added the polish language to the ClamAV Gui

@ArsenTech
Copy link
Copy Markdown
Owner

ArsenTech commented Mar 26, 2026

The Polish translation looks good overall.
Just a few small fixes needed:

  • Missing keys in /src-tauri/assets/i18n/pl.json (I added existing Polish translations on some parts)

I've slightly tweaked the "translated-by" key + used existing translations for

  • about.title
  • about.version

All for clarity

@ArsenTech ArsenTech self-requested a review as a code owner March 26, 2026 16:52
Copy link
Copy Markdown
Owner

@ArsenTech ArsenTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the Polish Translation is ok. Only some things left to translate:

  • tray.open
  • tray.about
  • tray.scan.main
  • tray.scan.full
  • tray.scan.custom
  • tray.scan.file
  • tray.quit
  • tray.tooltip

Make sure to translate these in /src-tauri/assets/i18n/pl.json

@@ -0,0 +1,17 @@
{
"tray": {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to translate those empty strings starting from here inside the /src-tauri/assets/i18n/pl.json

@ArsenTech
Copy link
Copy Markdown
Owner

ArsenTech commented Mar 26, 2026

It took longer than expected because of 2 reasons:

  • I should've figured out how to check out the PR and manage it locally
  • The build workflow fix took longer than expected

At least it works! Let me know if you've translated missing keys in /src-tauri/assets/i18n/pl.json because the system tray translation is needed:

  • tray.open
  • tray.about
  • tray.scan.main
  • tray.scan.full
  • tray.scan.custom
  • tray.scan.file
  • tray.quit
  • tray.tooltip

To make translations easier, use the English translation as a reference:
/src-tauri/assets/i18n/en.json
And translate missing keys into 🇵🇱 Polish

Note

  • Please keep key structure identical to en
  • Avoid changing key names
  • Keep placeholders (if any)

So I'll review and merge the Pull Request making your contribution live 😉

@ArsenTech ArsenTech added the i18n contribution Some languages can be added or updated label Mar 27, 2026
@ArsenTech
Copy link
Copy Markdown
Owner

ArsenTech commented Mar 27, 2026

Hi! I created a new PR with a cleaner commit history and only the relevant changes to the 🇵🇱 Polish Contribution:

Cleaner version of the PR: #6

Closing this one to keep things focused 👍

@ArsenTech ArsenTech closed this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n contribution Some languages can be added or updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants