fix(ast lowerer): add arity check for 'pop' and 'pop!'

src/arkreactor/Compiler/Lowerer/ASTLowerer.cpp

@@ -359,6 +359,8 @@ namespace Ark::internal
             buildAndThrowError(fmt::format("Can not use {} with less than 2 arguments", name), head);
         if (std::cmp_greater(argc, MaxValue16Bits))
             buildAndThrowError(fmt::format("Too many arguments ({}), exceeds {}", argc, MaxValue16Bits), x);
+        if (argc != 2 && (inst == POP_LIST || inst == POP_LIST_IN_PLACE))
+            buildAndThrowError(fmt::format("Expected 2 arguments (list, index) for {}, got {}", name, argc), head);
         if (argc != 3 && inst == SET_AT_INDEX)
             buildAndThrowError(fmt::format("Expected 3 arguments (list, index, value) for {}, got {}", name, argc), head);
         if (argc != 4 && inst == SET_AT_2_INDEX)

tests/unittests/resources/DiagnosticsSuite/compileTime/pop_list_in_place_too_many_args.ark

@@ -0,0 +1,2 @@
+(mut a [0 1 2 3])
+(pop! a 0 1 2 3)

tests/unittests/resources/DiagnosticsSuite/compileTime/pop_list_in_place_too_many_args.expected

@@ -0,0 +1,6 @@
+In file tests/unittests/resources/DiagnosticsSuite/compileTime/pop_list_in_place_too_many_args.ark:2
+    1 | (mut a [0 1 2 3])
+    2 | (pop! a 0 1 2 3)
+      |  ^~~~
+    3 |
+        Expected 2 arguments (list, index) for pop!, got 5

tests/unittests/resources/DiagnosticsSuite/compileTime/pop_list_too_many_args.ark

@@ -0,0 +1,2 @@
+(mut a [0 1 2 3])
+(pop a 0 1 2 3)

tests/unittests/resources/DiagnosticsSuite/compileTime/pop_list_too_many_args.expected

@@ -0,0 +1,6 @@
+In file tests/unittests/resources/DiagnosticsSuite/compileTime/pop_list_too_many_args.ark:2
+    1 | (mut a [0 1 2 3])
+    2 | (pop a 0 1 2 3)
+      |  ^~~
+    3 |
+        Expected 2 arguments (list, index) for pop, got 5