Skip to content

Conversation

@ybensacq
Copy link
Contributor

Description

  1. endpoint to return event types filters

What type of PR is this? (check all applicable)

  • πŸ• Feature (feat:)
  • πŸ› Bug Fix (fix:)
  • πŸ“ Documentation Update (docs:)
  • 🎨 Style (style:)
  • πŸ§‘β€πŸ’» Code Refactor (refactor:)
  • πŸ”₯ Performance Improvements (perf:)
  • βœ… Test (test:)
  • πŸ€– Build (build:)
  • πŸ” CI (ci:)
  • πŸ“¦ Chore (chore:)
  • ⏩ Revert (revert:)
  • πŸš€ Breaking Changes (BREAKING CHANGE:)

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ Documentation
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?


PR Title and Description Guidelines:

  • Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs.
  • Use types like feat:, fix:, chore:, BREAKING CHANGE: etc. in your PR title.
  • Your PR title will be used as a commit message when merging. Make sure it adheres to Conventional Commits standards.

Closing Issues

@linear
Copy link

linear bot commented Oct 10, 2024

@vercel
Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
ark-indexer-admin βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 17, 2024 7:10pm
indexer-marketplace-admin βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 17, 2024 7:10pm

Comment on lines +64 to +70
#[utoipa::path(
tag = "Collections",
responses(
(status = 200, description = "Get event filters", body = LastSalesResponse),
(status = 400, description = "Data not found", body = String),
)
)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attention mauvais copier/coller ici pour la desc et le tag.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'autre part les diffΓ©rentes valeurs de retour n'apparaissent pas sur le swagger

@remiroyc remiroyc force-pushed the feature/dev-860-duplicate-events-filters branch from c349cfe to f8774ac Compare November 29, 2024 12:13
@vercel
Copy link

vercel bot commented Nov 29, 2024

@ybensacq is attempting to deploy a commit to the Screenshot team on Vercel, but is not a member of this team. To resolve this issue, you can:

  • Make your repository public. Collaboration is free for open source and public repositories.
  • Add @ybensacq as a member. A Pro subscription is required to access Vercel's collaborative features.
    • If you're the owner of the team, click here and add @ybensacq as a member.
    • If you're the user who initiated this build request, click here to request access.
    • If you're already a member of the Screenshot team, make sure that your Vercel account is connected to your GitHub account.

To read more about collaboration on Vercel, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants