Skip to content

Conversation

@ptisserand
Copy link
Contributor

@ptisserand ptisserand commented Aug 26, 2024

Description

  1. Use same activity types across token collection and portfolio
  2. fix: from_address and to_address doesn't exist in token_offer table

Depends on: #533

What type of PR is this? (check all applicable)

  • 🍕 Feature (feat:)
  • 🐛 Bug Fix (fix:)
  • 📝 Documentation Update (docs:)
  • 🎨 Style (style:)
  • 🧑‍💻 Code Refactor (refactor:)
  • 🔥 Performance Improvements (perf:)
  • ✅ Test (test:)
  • 🤖 Build (build:)
  • 🔁 CI (ci:)
  • 📦 Chore (chore:)
  • ⏩ Revert (revert:)
  • 🚀 Breaking Changes (BREAKING CHANGE:)

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 Documentation
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?


PR Title and Description Guidelines:

  • Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs.
  • Use types like feat:, fix:, chore:, BREAKING CHANGE: etc. in your PR title.
  • Your PR title will be used as a commit message when merging. Make sure it adheres to Conventional Commits standards.

Closing Issues

@linear
Copy link

linear bot commented Aug 26, 2024

@vercel
Copy link

vercel bot commented Aug 26, 2024

@ptisserand is attempting to deploy a commit to the Screenshot Team on Vercel.

To accomplish this, @ptisserand needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@ptisserand ptisserand force-pushed the feature/dev-704-unify-activity-types-across-token-collection-and-portfolio branch from 44658f7 to 25a38aa Compare August 30, 2024 06:05
@ptisserand ptisserand marked this pull request as ready for review August 30, 2024 06:34
@ptisserand ptisserand requested a review from ybensacq August 30, 2024 06:34
@remiroyc remiroyc changed the base branch from main to staging October 2, 2024 15:49
@remiroyc remiroyc force-pushed the staging branch 11 times, most recently from 2dff9f2 to aea61fd Compare October 10, 2024 22:42
@remiroyc remiroyc changed the base branch from staging to main October 11, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants